From 90ee713a58fb19791b3ffc7d4c9b3d1e1bf24d9d Mon Sep 17 00:00:00 2001 From: netblue30 Date: Fri, 8 Nov 2019 10:59:18 -0500 Subject: Disabled --overlay for kernels 4.219 and newer until we can bring a fix in --- src/firejail/fs.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/firejail/fs.c b/src/firejail/fs.c index 0f920996d..3df551d4c 100644 --- a/src/firejail/fs.c +++ b/src/firejail/fs.c @@ -889,6 +889,13 @@ void fs_overlayfs(void) { if (major == 3 && minor < 18) oldkernel = 1; + // mounting an overlayfs on top of / seems to be broken for kernels > 4.19 + // we disable overlayfs for now, pending fixing + if (major >= 4 &&minor >= 19) { + fprintf(stderr, "Error: OverlayFS disabled for Linux kernels 4.19 and newer, pending fixing.\n"); + exit(1); + } + char *oroot = RUN_OVERLAY_ROOT; mkdir_attr(oroot, 0755, 0, 0); @@ -982,8 +989,10 @@ void fs_overlayfs(void) { else { // kernel 3.18 or newer if (asprintf(&option, "lowerdir=/,upperdir=%s,workdir=%s", odiff, owork) == -1) errExit("asprintf"); - if (mount("overlay", oroot, "overlay", MS_MGC_VAL, option) < 0) + if (mount("overlay", oroot, "overlay", MS_MGC_VAL, option) < 0) { + fprintf(stderr, "Debug: running on kernel version %d.%d\n", major, minor); errExit("mounting overlayfs"); + } //*************************** // issue #263 start code -- cgit v1.2.3-54-g00ecf