From 1fb814e51149d105233f1edc1abb0de202f71b4d Mon Sep 17 00:00:00 2001 From: "Kelvin M. Klann" Date: Fri, 13 May 2022 19:33:12 -0300 Subject: Makefile.in: stop running distclean on dist distclean erases user-made modifications to the files generated by the configure script; it is not obvious that a non-"clean" target would ever run it. That is, instead of: ./configure --enable-foo && make distclean && make dist It would probably be safer (and more maintainable) to do: make distclean && ./configure --enable-foo && make dist So drop the distclean call and the file-moving hacks around it. Added on commit 137985136 ("Baseline firejail 0.9.28", 2015-08-08). Relates to commit 684919100 ("bug: preserve config.status during make dist", 2016-09-19) and commit 31dc1218a ("fixups", 2020-07-19). --- Makefile.in | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Makefile.in b/Makefile.in index 945e30e84..0e80fb43a 100644 --- a/Makefile.in +++ b/Makefile.in @@ -207,11 +207,6 @@ DISTFILES = "src etc m4 platform contrib configure configure.ac Makefile.in inst DISTFILES_TEST = "test/Makefile.in test/apps test/apps-x11 test/apps-x11-xorg test/root test/private-lib test/fnetfilter test/fcopy test/environment test/profiles test/utils test/compile test/filters test/network test/fs test/sysutils test/chroot" dist: - mv config.status config.status.old - mv mkdeb.sh mkdeb.sh.old - make distclean - mv mkdeb.sh.old mkdeb.sh - mv config.status.old config.status rm -fr $(NAME)-$(VERSION) $(NAME)-$(VERSION).tar.xz mkdir -p $(NAME)-$(VERSION)/test cp -a "$(DISTFILES)" $(NAME)-$(VERSION) -- cgit v1.2.3-70-g09d2