From 0545762da33ad670681f7c2570eadcd831d14278 Mon Sep 17 00:00:00 2001 From: Aleksey Manevich Date: Sat, 30 Jul 2016 15:30:47 +0300 Subject: exit with error if length of quoted command line is longer than ARG_MAX --- src/firejail/cmdline.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/firejail/cmdline.c b/src/firejail/cmdline.c index 9818f8ffa..517124d9e 100644 --- a/src/firejail/cmdline.c +++ b/src/firejail/cmdline.c @@ -132,6 +132,10 @@ void quote_cmdline(char *command_line, char *window_title, int len, int argc, ch void build_cmdline(char **command_line, char **window_title, int argc, char **argv, int index) { int len = cmdline_length(argc, argv, index); + if (len > ARG_MAX) { + errno = E2BIG; + errExit("cmdline_length"); + } *command_line = malloc(len + 1); if (!*command_line) -- cgit v1.2.3-54-g00ecf