From 15e40e9ae48dcab4f317215fe5aef8a58f7259dc Mon Sep 17 00:00:00 2001
From: "Kelvin M. Klann" <kmk3.code@protonmail.com>
Date: Tue, 25 Apr 2023 13:42:08 -0300
Subject: ci: standardize apt-get update/install

General changes:

* Use a single -q on update, as the output is not too long
* Use a single -q on install, to show all packages at once

GitLab-specific changes:

* Use `DEBIAN_FRONTEND=noninteractive` to reduce noise
* Use --no-install-recommends to avoid installing unnecessary packages
* Filter out uninteresting lines on install

Note: `DEBIAN_FRONTEND` does not appear to be needed in the default
GitHub runner container and not many packages are currently being
downloaded/installed in them, so do the above changes only jobs that use
custom Docker images.
---
 .github/workflows/build-extra.yml | 24 ++++++++++++++----------
 .github/workflows/build.yml       |  4 ++--
 2 files changed, 16 insertions(+), 12 deletions(-)

(limited to '.github/workflows')

diff --git a/.github/workflows/build-extra.yml b/.github/workflows/build-extra.yml
index 32a8969d6..e32f827e1 100644
--- a/.github/workflows/build-extra.yml
+++ b/.github/workflows/build-extra.yml
@@ -62,9 +62,11 @@ jobs:
           github.com:443
     - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
     - name: update package information
-      run: sudo apt-get update
+      run: sudo apt-get update -qy
     - name: install dependencies
-      run: sudo apt-get install libapparmor-dev libselinux1-dev
+      run: >
+        sudo apt-get install -qy
+        libapparmor-dev libselinux1-dev
     - name: print env
       run: ./ci/printenv.sh
     - name: configure
@@ -90,9 +92,11 @@ jobs:
           github.com:443
     - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
     - name: update package information
-      run: sudo apt-get update
+      run: sudo apt-get update -qy
     - name: install clang-tools-14 and dependencies
-      run: sudo apt-get install clang-tools-14 libapparmor-dev libselinux1-dev
+      run: >
+        sudo apt-get install -qy
+        clang-tools-14 libapparmor-dev libselinux1-dev
     - name: print env
       run: ./ci/printenv.sh
     - name: configure
@@ -114,9 +118,9 @@ jobs:
           github.com:443
     - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
     - name: update package information
-      run: sudo apt-get update
+      run: sudo apt-get update -qy
     - name: install cppcheck
-      run: sudo apt-get install cppcheck
+      run: sudo apt-get install -qy cppcheck
     - run: cppcheck --version
     - name: cppcheck
       run: >
@@ -136,9 +140,9 @@ jobs:
           github.com:443
     - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
     - name: update package information
-      run: sudo apt-get update
+      run: sudo apt-get update -qy
     - name: install cppcheck
-      run: sudo apt-get install cppcheck
+      run: sudo apt-get install -qy cppcheck
     - run: cppcheck --version
     - name: cppcheck
       run: cppcheck -q --force --error-exitcode=1 --enable=warning,performance .
@@ -154,9 +158,9 @@ jobs:
           github.com:443
     - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
     - name: update package information
-      run: sudo apt-get update
+      run: sudo apt-get update -qy
     - name: install dependencies
-      run: sudo apt-get install codespell
+      run: sudo apt-get install -qy codespell
     - run: codespell --version
     - name: codespell
       run: make codespell
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 82ec9b5bf..ea85e1109 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -63,10 +63,10 @@ jobs:
           yahoo.com:1025
     - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
     - name: update package information
-      run: sudo apt-get update
+      run: sudo apt-get update -qy
     - name: install dependencies
       run: >
-        sudo apt-get install
+        sudo apt-get install -qy
         gcc-12 libapparmor-dev libselinux1-dev expect xzdec whois
         bridge-utils
     - name: print env
-- 
cgit v1.2.3-54-g00ecf