aboutsummaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAge
* jailcheck: fix wrong program name in --versionLibravatar Kelvin M. Klann2023-05-12
| | | | | Added on commit 42e2db127 ("jaitest - simple sandbox testing utility program", 2021-02-20).
* etc-cleanup: fix wrong header path in MakefileLibravatar Kelvin M. Klann2023-05-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is causing main.o to be built using an implicit rule (rather than the rule from src/prog.mk), which does not use PROG_CFLAGS. Example (using src/fldd as a working example for comparison): $ make -C src/etc-cleanup clean >/dev/null && make -C src/etc-cleanup | grep -Ev '(Entering|Leaving) directory' gcc -g -O2 -c -o main.o main.c gcc -pie -fPIE -Wl,-z,relro -Wl,-z,now -o etc-cleanup main.o $ make -C src/etc-cleanup clean >/dev/null && make -C src/etc-cleanup -r | grep -Ev '(Entering|Leaving) directory' make: *** No rule to make target 'main.o', needed by 'etc-cleanup'. Stop. $ make -C src/fldd clean >/dev/null && make -C src/fldd | grep -Ev '(Entering|Leaving) directory' gcc -ggdb -O2 -DVERSION='"0.9.73"' -fstack-protector-all [...] gcc -pie -fPIE -Wl,-z,relro -Wl,-z,now -o fldd main.o ../lib/common.o ../lib/ldd_utils.o $ make -C src/fldd clean >/dev/null && make -C src/fldd -r | grep -Ev '(Entering|Leaving) directory' gcc -ggdb -O2 -DVERSION='"0.9.73"' -fstack-protector-all [...] gcc -pie -fPIE -Wl,-z,relro -Wl,-z,now -o fldd main.o ../lib/common.o ../lib/ldd_utils.o Environment: GNU make 4.4.1-2 on Artix Linux. This amends commit e889db095 ("build fix", 2023-02-06). See also commit 02d37680c ("private-etc rework: file groups moved to src/include/etc_groups.h, new groups added", 2023-01-25). Relates to #5610.
* sbox: improve seccomp blacklistLibravatar smitsohu2023-05-09
|
* arp.c: ensure positive timeout on select(2)Libravatar Kelvin M. Klann2023-05-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Log from build_and_test[1]: TESTING: network scan (net_scan.exp) [...] firejail /bin/bash Child process initialized in 1704.83 ms spawn /bin/bash firejail --net=br0 --ip=10.10.20.60 runner@fv-az576-472:~/work/firejail/firejail/test/network$ <l/test/network$ firejail --net=br0 --ip=10.10.20.60 Reading profile /etc/firejail/default.profile Reading profile /etc/firejail/disable-common.inc Reading profile /etc/firejail/disable-programs.inc ** Note: you can use --noprofile to disable default.profile ** Error select: arp.c:202 arp_check: Invalid argument runner@fv-az576-472:~/work/firejail/firejail/test/network$ TESTING ERROR 4 This "Invalid argument" error does not always happen, so I assume that it may be due to a negative integer value in `ts` when calling select. Misc: Found in #5805. [1] https://github.com/netblue30/firejail/actions/runs/4806275219/jobs/8553597462
* New profile: url-eater (#5780)Libravatar glitsj162023-04-18
| | | | | * Create url-eater.profile * RELNOTES: add url-eater to 'new profiles'
* fix for old compilersLibravatar netblue302023-04-06
|
* Merge pull request #5710 from pirate486743186/mov-cliLibravatar netblue302023-03-23
|\ | | | | add mov-cli.profile
| * add mov-cliLibravatar pirate4867431862023-03-04
| |
* | Merge pull request #5737 from glitsj16/private-etc-bugfixLibravatar netblue302023-03-23
|\ \ | | | | | | fs_etc.c: conditionally create /etc/resolv.conf
| * | fs_etc.c: fix misleading indentationLibravatar glitsj162023-03-15
| | |
| * | fs_etc.c: conditionally create /etc/resolv.confLibravatar glitsj162023-03-15
| | |
* | | util.c: add and use ascii-only char functionsLibravatar Kelvin M. Klann2023-03-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "invalid_name" function claims to "allow strict ASCII letters and numbers". However, it uses isalnum(3) and isdigit(3), which may take the current locale into account and thus return 1 for non-ASCII characters. So add the following functions: * ascii_isalnum * ascii_isalpha * ascii_isdigit * ascii_islower * ascii_isupper * ascii_isxdigit And use the applicable ones in "invalid_name" so that it actually uses strictly ASCII in its comparisons. Added on commit b4ffaa207 ("merges; more on cleaning up esc chars", 2023-02-14). Relates to #5578. Kind of relates to #5708.
* | | firejail.h: move invalid_name prototype to proper placeLibravatar Kelvin M. Klann2023-03-20
| | | | | | | | | | | | | | | | | | | | | Follow the same order as on util.c. Added on commit b4ffaa207 ("merges; more on cleaning up esc chars", 2023-02-14).
* | | Add profiles for jami and postman (#5691)Libravatar Kobaxidze2562023-03-15
|/ /
* | microsoft-edge fixes (#5697)Libravatar glitsj162023-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | * microsoft-edge*: fix spacing * Create microsoft-edge-stable.profile Relates to #5696. * firecfg.config: add support for microsoft-edge-stable redirect * disable-common.inc: blacklist msedge SUID executables * microsoft-edge: add private-opt and allow internal sandbox access
* | Add Discord PTB profileLibravatar Neotamandua2023-03-12
| |
* | firejail.txt: remove extraneous endifLibravatar Kelvin M. Klann2023-03-10
| | | | | | | | | | | | | | Added on commit b689b69f6 ("make --private-lib a compile time option, disabled by default", 2023-03-09). Relates to #5727.
* | allow symlinks for .asoundrc - part 2 (#5709)Libravatar netblue302023-03-09
| |
* | allow symlinks for .asoundrc (5709)Libravatar netblue302023-03-09
| |
* | private-lib cleanupLibravatar netblue302023-03-09
| |
* | make --private-lib a compile time option, disabled by defaultLibravatar netblue302023-03-09
| |
* | testingLibravatar netblue302023-03-09
| |
* | Merge pull request #5707 from pirate486743186/ani-cliLibravatar netblue302023-03-08
|\ \ | | | | | | add ani-cli.profile
| * | add ani-cli.profileLibravatar pirate4867431862023-03-05
| |/ | | | | | | https://github.com/pystardust/ani-cli
* | Merge pull request #5714 from pirate486743186/porn-cliLibravatar netblue302023-03-08
|\ \ | | | | | | add porn-cli.profile
| * | add porn-cli.profileLibravatar pirate4867431862023-03-05
| | |
* | | Merge pull request #5706 from pirate486743186/lobsterLibravatar netblue302023-03-08
|\ \ \ | | | | | | | | add lobster.profile
| * | | add lobster.profileLibravatar pirate4867431862023-03-03
| | |/ | |/| | | | | | | https://github.com/justchokingaround/lobster
* | | remove firemon --interface option - it is a duplication of firejail --net.printLibravatar netblue302023-03-08
| | |
* | | add ipv6 support in --net.printLibravatar netblue302023-03-08
| | |
* | | remove DNS lookup for --netfilter.print and --netfilter6.print commandsLibravatar netblue302023-03-07
| | |
* | | testingLibravatar netblue302023-03-07
| | |
* | | Run make codespellLibravatar Kelvin M. Klann2023-03-07
| | | | | | | | | | | | Environment: codespell 2.2.2-3 on Artix Linux.
* | | testingLibravatar netblue302023-03-06
| |/ |/|
* | Merge branch 'master' of ssh://github.com/netblue30/firejailLibravatar netblue302023-03-05
|\ \
| * \ Merge pull request #5708 from layderv/escape-cntrl-s2Libravatar netblue302023-03-04
| |\ \ | | | | | | | | Forbid control chars in names
| | * | Forbid control chars in namesLibravatar layderv2023-03-03
| | |/
* | / codespell github actionLibravatar netblue302023-03-05
|/ /
* / cleanup appimageLibravatar netblue302023-03-04
|/
* cleanupLibravatar smitsohu2023-03-02
|
* cleanupLibravatar smitsohu2023-03-02
|
* fix cppcheck/scan-build problemsLibravatar netblue302023-02-27
|
* random hostname by default; fix --hostname and --hosts-fileLibravatar netblue302023-02-27
|
* Merge pull request #5674 from kmk3/fix-ws-add-editorconfigLibravatar netblue302023-02-24
|\ | | | | build: Fix whitespace and add .editorconfig
| * editorconfig: add indentation rulesLibravatar Kelvin M. Klann2023-02-20
| | | | | | | | | | | | | | | | | | | | Commands used to list the file extensions used in the project: $ git ls-files | sed -En 's/.*(\.[^.]+)$/\1/p' | LC_ALL=C sort | uniq -c For rules that are more specific to a given directory, put a dedicated .editorconfig file in it.
| * Fix inconsistent leading spacesLibravatar Kelvin M. Klann2023-02-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: * Fix spaces being used for indentation in some lines in C * Remove leading spaces before some goto labels * Remove leading spaces before the start of some multiline comments * Change leading spaces to tabs in some multiline macros * Add missing asterisk to some multiline comments (to match other multiline comments and because they are false positives in the commands below) Note: Leading spaces can be used for alignment (such as in function parameters and function arguments in C) and for line continuation (such as in long commands in shell scripts). However, in the above changes the leading spaces are used for other reasons and do not seem to fit with the style used. Commands used to search for errors: $ git grep -In '^ [^*]' | grep -E -v \ -e '(COPYING|README|RELNOTES|configure(.ac)?):' \ -e '^[^:]+.(md|yml|py):' -e '(bash|zsh)_completion/' \ -e '^contrib/syntax/' -e '^etc/templates/.*\.txt:' -e '^m4/' \ -e '^platform/debian/' -e '^src/man/.*\.txt:' \ -e '.*mkrpm.sh:' -e '.*extract_errnos.sh:'
| * extract_seccomp.c: use "do while" in macro definitionLibravatar Kelvin M. Klann2023-02-20
| | | | | | | | | | | | | | To match the common usage; see for example src/firejail/firejail.h. Added on commit 960b4daba ("add tool to dump seccomp filters", 2020-02-17).
| * docs: improve grammar in --join-or-start= commentsLibravatar Kelvin M. Klann2023-02-20
| |
| * Fix space before/after tab in indentLibravatar Kelvin M. Klann2023-02-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes all of the "space before tab in indent" errors raised by git: $ git diff --check 4b825dc642cb6eb9a060e54bf8d69288fbee4904..HEAD | grep '^[^+]' | cut -f 3 -d : | LC_ALL=C sort | uniq -c 72 space before tab in indent. Commands used to find the errors: $ git diff --check 4b825dc642cb6eb9a060e54bf8d69288fbee4904..HEAD $ git grep -In "$(printf '\t') " Note: Unlike "space before tab in indent", the reverse ("space after tab in indent") is not reported by git. That is because spaces could be intentionally used for alignment or line continuation, but in some cases they are being used for indentation together with tabs and in others the formatting is misaligned. The second command was used to help find and fix these other issues.
| * Fix EOL at EOFLibravatar Kelvin M. Klann2023-02-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commands used to search and replace: $ git grep -Ilz '.' | xargs -0 -I '{}' sh -c \ "printf '%s\n' \"\$(cat '{}')\" >'{}'" The above commands ensure that there is exaclty 1 line terminator at EOF (rather than 0 or more than 1) on all non-empty text files. This fixes all of the "new blank line at EOF" errors raised by git: $ git diff --check 4b825dc642cb6eb9a060e54bf8d69288fbee4904..HEAD | grep '^[^+]' | cut -f 3 -d : | LC_ALL=C sort | uniq -c 21 new blank line at EOF. 72 space before tab in indent. 4 trailing whitespace.