aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAge
...
| * | | | | | sort.py: use script name in usage/main docstringLibravatar Kelvin M. Klann2022-10-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With this, the help section remains consistent regardless of how the script is called and even if the filename is changed. For example, if someone renames "sort.py" to "firejail-sort" and puts it somewhere in `$PATH`. Example outputs of the script name (using `print(argv[0]); return`): $ ./contrib/sort.py ./contrib/sort.py $ python contrib/sort.sh contrib/sort.py $ (cd contrib && ./sort.py) ./sort.py Note: This depends on `os.path` and `sys.argv`, so the imports have to appear before the docstring. In which case, the docstring has to be explicitly assigned to `__doc__` (as it ceases to be the first statement in the file). Note2: When running `pydoc ./contrib/sort.py`, `argv[0]` becomes "/usr/bin/pydoc" (using python 3.10.8-1 on Artix Linux).
| * | | | | | sort.py: print usage if there are no argumentsLibravatar Kelvin M. Klann2022-10-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | And return a specific exit code, as suggested by @rusty-snake[1]. Escape the first line in the docstring to avoid printing a blank line as the first line of the output. [1] https://github.com/netblue30/firejail/pull/5429#discussion_r999637842
| * | | | | | sort.py: print more standard error messagesLibravatar Kelvin M. Klann2022-10-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Where applicable, instead of creating custom ones. Example error messages: rm -f 123 && ./contrib/sort.py 123 [ Error ] [Errno 2] No such file or directory: '123' touch 123 && chmod -rwx 123 && ./contrib/sort.py 123 [ Error ] [Errno 13] Permission denied: '123'
| * | | | | | sort.py: print errors to stderrLibravatar Kelvin M. Klann2022-10-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Misc: The trailing comma is due to using the opinionated `black` Python formatter (which seems to be a relatively common one). This was the only change made, so the code seems to already be following the format used by this tool.
| * | | | | | sort.py: line-wrap and improve commentsLibravatar Kelvin M. Klann2022-10-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: * Line-wrap comments at 79 characters * Make comments clearer * Make main docstring more similar to a command "usage" output See the result with the following command, which generates a man-page-like output and opens it in the man pager (such as in `less`): $ pydoc ./contrib/sort.py See also PEP-257, "Docstring Conventions"[1]. [1] https://peps.python.org/pep-0257/
| * | | | | | sort.py: rename protocols to original_protocolsLibravatar Kelvin M. Klann2022-10-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To make it clearer. There are 3 different instances of protocol-related objects being used in the fix_protocol function: * The input * The array of common sorted lines * The (sorted) output
| * | | | | | sort.py: rename raw_items to original_itemsLibravatar Kelvin M. Klann2022-10-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To make it clearer. Both the input and output of the sort_alphabetical function are strings of comma-separated items, so there is no format conversion of any kind being done (from "raw" to "not raw"), only sorting.
| * | | | | | sort.py: simplify "checking" message codeLibravatar Kelvin M. Klann2022-10-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Which also makes it fit in under 80 characters. Always print "profile(s)" instead of changing the message based on the argument count.
| * | | | | | sort.py: pass the str.casefold function directlyLibravatar Kelvin M. Klann2022-10-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | To the sort function, instead of wrapping it in a lambda function.
| * | | | | | sort.py: enumerate lines from 1Libravatar Kelvin M. Klann2022-10-18
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | Instead of manually adding 1 to lineno.
* | | | | | fix opening links in firefox youtube-viewers-common.profile (#5352)Libravatar pirate4867431862022-11-23
| | | | | | | | | | | | | | | | | | Co-authored-by: pirate486743186 <>
* | | | | | Add python3 support/fixes to nicotine (#5459)Libravatar glitsj162022-11-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add python3 support to nicotine * Revert private-bin changes Adding shell and python3 support to private-bin kept breaking nicotine for the user who reported it on IRC. Let's revert it as suggested by @rusty-snake.
* | | | | | Merge pull request #5473 from ↵Libravatar Fred Barclay2022-11-22
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | netblue30/dependabot/github_actions/step-security/harden-runner-2.0.0 build(deps): bump step-security/harden-runner from 1.5.0 to 2.0.0
| * | | | | | build(deps): bump step-security/harden-runner from 1.5.0 to 2.0.0dependabot/github_actions/step-security/harden-runner-2.0.0Libravatar dependabot[bot]2022-11-14
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 1.5.0 to 2.0.0. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](https://github.com/step-security/harden-runner/compare/2e205a28d0e1da00c5f53b161f4067b052c61f34...ebacdc22ef6c2cfb85ee5ded8f2e640f4c776dd5) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | | | RELNOTES: add featuresLibravatar Kelvin M. Klann2022-11-22
| |_|_|_|/ |/| | | | | | | | | | | | | | Relates to #5188 #5217 #5271.
* | | | | RELNOTES: add docsLibravatar Kelvin M. Klann2022-11-20
| | | | | | | | | | | | | | | | | | | | Relates to #5398 #5402 #5451.
* | | | | Merge pull request #5451 from kmk3/docs-clarify-appimageLibravatar Kelvin M. Klann2022-11-20
|\ \ \ \ \ | |/ / / / |/| | | | docs: clarify that --appimage should appear before --profile
| * | | | docs: clarify that --appimage should appear before --profileLibravatar Kelvin M. Klann2022-11-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | And fix the argument order in the examples to reflect that. Background: The order in which these options appeared in the documentation was inconsistent. src/man/firejail.txt used --appimage before --profile and src/man/firejail-profile.txt used --profile before --appimage. Then commit 44fefcac0 ("Make appimage examples consistent with --appimage option short description", 2022-10-05) / PR #5402 was made, which standardized on --profile before --appimage in both places. But as mentioned by @rusty-snake[1], --appimage has be specified before --profile in order for any `?HAS_APPIMAGE` conditionals inside of the profile to evaluate to true. So change the documentation to use and recommend the latter form. Also, add --quiet to one example to make it clear that --appimage does not have to be the first option (nor the last option before --profile). [1] https://github.com/netblue30/firejail/pull/5402#issuecomment-1274889618
* | | | | Add support for cinelerra-gg (#5467)Libravatar glitsj162022-11-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Create cinelerra-gg * add cinelerra-gg to `New profiles` section * Add cinelerra-gg to firecfg.config
* | | | | build(deps): bump github/codeql-action from 2.1.29 to 2.1.31Libravatar dependabot[bot]2022-11-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.29 to 2.1.31. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/ec3cf9c605b848da5f1e41e8452719eb1ccfb9a6...c3b6fce4ee2ca25bc1066aa3bf73962fda0e8898) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | | Add netlink to list of allowed protocols (#5464)Libravatar Jan Sonntag2022-11-10
| | | | | | | | | | | | | | | Fixes #5463 by adding netlink to the list of allowed protocols
* | | | | Add godot3 redirect (#5456)Libravatar Frostbyte46642022-11-07
|/ / / / | | | | | | | | | | | | | | | | * Create godot3.profile * Add godot3 redirect to firecfg.config
* | | | RELNOTES: add build: Fix musl warningsLibravatar Kelvin M. Klann2022-11-03
| | | | | | | | | | | | | | | | Relates to #5421 #5431.
* | | | RELNOTES: add missing issue referenceLibravatar Kelvin M. Klann2022-11-03
| |_|/ |/| | | | | | | | Relates to #5356.
* | | [StepSecurity] ci: Harden GitHub ActionsLibravatar StepSecurity Bot2022-10-31
| | | | | | | | | Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
* | | build(deps): bump github/codeql-action from 2.1.28 to 2.1.29Libravatar dependabot[bot]2022-10-31
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.28 to 2.1.29. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/cc7986c02bac29104a72998e67239bb5ee2ee110...ec3cf9c605b848da5f1e41e8452719eb1ccfb9a6) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | Fix freetube mpris supportLibravatar rusty-snake2022-10-30
| | | | | | | | Closes #5437
* | build(deps): bump github/codeql-action from 2.1.27 to 2.1.28Libravatar dependabot[bot]2022-10-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.27 to 2.1.28. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/807578363a7869ca324a79039e6db9c843e0e100...cc7986c02bac29104a72998e67239bb5ee2ee110) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | compile fixLibravatar netblue302022-10-25
| |
* | nettrace: various fixesLibravatar netblue302022-10-25
| |
* | fix nolocal netfilterLibravatar netblue302022-10-25
| |
* | removed grsecurity supportLibravatar netblue302022-10-24
| |
* | --icmptraceLibravatar netblue302022-10-24
| |
* | Merge pull request #5431 from netblue30/musl_warningsLibravatar Reiner Herrmann2022-10-23
|\ \ | | | | | | Fix musl warnings
| * | check for availability of symbols instead of glibc definesLibravatar Reiner Herrmann2022-10-23
| | | | | | | | | | | | in musl they are just redefines of the non-64 versions
| * | include limits.h instead of manually defining LINE_MAXLibravatar Reiner Herrmann2022-10-23
|/ /
* | remove deprecated --shell from man pageLibravatar netblue302022-10-23
| |
* | dnstrace and snitraceLibravatar netblue302022-10-23
|/
* Merge branch 'master' of ssh://github.com/netblue30/firejailLibravatar netblue302022-10-11
|\
| * Merge pull request #5389 from glitsj16/qutebrowser-fixesLibravatar netblue302022-10-11
| |\ | | | | | | Harden qutebrowser profile
| | * Harden qutebrowserLibravatar glitsj162022-10-03
| | |
| | * Fix D-Bus mpris supportLibravatar glitsj162022-10-02
| | |
| | * unbreak D-Bus mpris supportLibravatar glitsj162022-10-02
| | |
| | * Harden qutebrowser profileLibravatar glitsj162022-10-01
| | |
| * | Merge pull request #5402 from slowpeek/masterLibravatar netblue302022-10-11
| |\ \ | | | | | | | | docs: Make appimage examples consistent with --appimage option short description
| | * | Make appimage examples consistent with --appimage option short descriptionLibravatar slowpeek2022-10-05
| | | |
| * | | Merge pull request #5298 from pirate486743186/patch-1Libravatar netblue302022-10-11
| |\ \ \ | | | | | | | | | | electron-mail.profile refactoring
| | * | | electron-mail.profile: refactor and redirect to electron.profileLibravatar pirate4867431862022-10-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: - redirect to electron.profile - fix program name - update program description - allow /bin/sh - allow opening links in Firefox - remove no3d, nonewprivs, noroot, protocol, seccomp - add machine-id, nosound - remove private-bin, disable-mnt - harden private-etc - allow D-Bus notifications, secrets
* | | | | compile fixLibravatar netblue302022-10-11
|/ / / /
* | | | nettrace-dns and nettrace-sniLibravatar netblue302022-10-11
| | | |