| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
| |
Currently, the configure-time variables (that is, the ones that assign
to placeholders, such as "@HAVE_MAN@", which are set/replaced at
configure-time) are defined on multiple files (such as on Makefile.in
and on common.mk.in).
To avoid duplication, centralize these variables on a single file
(config.mk.in) and replace all of the other definitions of them with an
include of config.mk.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A non-absolute path on an include command is always treated as being
relative to the directory in which "make" was started in, rather than
being relative to the makefile that contains the command. For example,
given the following project structure and file contents:
* Makefile: include src/foo.mk
* src/foo.mk: include bar.mk
* src/bar.mk:
Running "make" on the root project directory (that is, where "Makefile"
is) yields the following:
src/foo.mk:1: bar.mk: No such file or directory
As "bar.mk" in "include bar.mk" is relative to the current (process)
directory (that is, "./bar.mk") and not to where foo.mk is located in
("./src/bar.mk").
So on every makefile that contains an include command, define the root
project directory in the ROOT variable and always include relative to
it, to later enable any included mkfiles to include other mkfiles
without having to worry about the correct path.
Commands used to search and replace:
$ git grep -Flz 'include ../common.mk' -- src |
xargs -0 -I '{}' sh -c \
"printf '%s\n' \"\`sed 's|include ../common.mk|ROOT = ../..\ninclude \$(ROOT)/src/common.mk|' '{}'\`\" >'{}'"
Environment: GNU make 4.3-3.1 on Artix Linux
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It currently claims to contain "common definitions for all makefiles",
but it is not included by all makefiles under src/ and it contains
variable definitions that may possibly clash with the ones defined on
certain makefiles. Mainly, the following makefiles (which are used for
building shared objects) use a different set of CFLAGS compared to
src/common.mk.in:
* src/libpostexecseccomp/Makefile.in
* src/libtrace/Makefile.in
* src/libtracelog/Makefile.in
Given the contents of common.mk.in, it seems to be intended only for
makefiles that build C programs and/or non-shared objects (which are
most of, but not all of the makefiles under src/), so put that in the
comment instead.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is no config.h nor config.h.in in the repository:
$ git ls-files -- '*config.h*'
$
The filename is only mentioned on the generated configure script, as a
generic example of an autoconf config file:
$ git grep -F -A 1 -B 2 config.h | grep -v '^Makefile.in'
--
configure-# Set up the scripts for CONFIG_FILES section.
configure-# No need to generate them if there are no CONFIG_FILES.
configure:# This happens for instance with `./config.status config.h'.
configure-if test -n "$CONFIG_FILES"; then
--
configure- # Let's still pretend it is `configure' which instantiates (i.e., don't
configure- # use $as_me), people would be surprised to read:
configure: # /* config.h. Generated by config.status. */
configure- configure_input='Generated from '`
|
| |
|
|
|
|
|
|
|
|
| |
To make it easier to read and edit them and to make the diffs clearer.
vim commands used to search and replace:
:0/DISTFILES/ | s/\v ([^=])/ \\\r\1/g | s/$/\r/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They are being double-quoted twice, as in `""$(DISTFILES)""`, which is
equivalent to not using quotes at all, as each double-quote pair gets
expanded into nothing, leaving only `$(DISTFILES)`.
Note that DISTFILES and DISTFILES_TEST are the only variables defined
with quoted values and that make does not work with filenames that
contain whitespace anyway.
Added on commit da19d2d1b ("Simplify dist target and add missing
test/sysutils to tarball", 2016-07-25) / PR #646.
|
| |
|
|
|
|
|
|
|
|
| |
To make it easier to read and edit them and to make the diffs clearer.
vim commands used to search and replace:
:0/AC_CONFIG_FILES/1 | ,+3s/ \\// | -3,+1s/ /\r/g
|
|
|
|
|
|
|
| |
An output message and some whitespace were changed on commit 9903aaa9c
("rel 0.9.68rc1 testing", 2022-01-18).
Environment: autoconf 2.69 (with the runstatedir patch) on Artix Linux
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit b4d0b24c533c8aebb8961bf658e3b41580b073e2.
This amends commit 56b86f8ac ("Revert "Makefile.in: stop running
distclean on dist"", 2022-06-08) / PR #5182. Since the revert, `make
dist` itself already runs `make distclean`.
This also means that it is no longer necessary to run ./configure (to
generate "Makefile" from "Makefile.in") before running
./contrib/fj-mkdeb.py.
Misc: This is not a clean revert.
Relates to #5154.
|
| |
|
| |
|
| |
|
|\
| |
| | |
RELNOTES: add new and removed profiles
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Commands used to find the profile:
$ git log --pretty= --graph --name-only \
--diff-filter=DBX 0.9.68..HEAD -- etc
$ tig --diff-filter=DXB 0.9.68..HEAD -- etc
Relates to #5058.
|
|/
|
|
|
|
|
|
|
|
|
|
| |
Profiles: opera-developer, node-gyp, npx, semver, ping-hardened.
Commands used to find the profiles:
$ git log --pretty= --graph --name-only \
--diff-filter=AC 0.9.68..HEAD -- etc
$ tig --diff-filter=AC 0.9.68..HEAD -- etc
Relates to #5001 #5058 #5061.
|
|
|
|
| |
Relates to #5111 #5122 #5155.
|
|
|
|
| |
Relates to #5110.
|
|
|
|
| |
Relates to #5133 #5154.
|
|\
| |
| | |
Revert "Makefile.in: stop running distclean on dist"
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 1fb814e51149d105233f1edc1abb0de202f71b4d.
If distclean is not executed before copying the files on dist, then the
generated files inside src/ are included in the dist archive:
$ ./configure >/dev/null && make distclean >/dev/null &&
./configure >/dev/null && make dist | grep 'Makefile$' | wc -l
26
This happens because src/ is copied wholesale on dist (see DISTFILES).
Revert the commit to ensure that only the input files (such as the
"Makefile.in" files) are archived.
Related discussion:
https://github.com/netblue30/firejail/pull/5154#pullrequestreview-980810845
Relates to #5142.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
the previous commit "CVE-2022-31214: fixing the fix"
made private-etc=fonts,fonts and similar commands
fail with an error
fix that regression by tolerating already existing
directories
|
| | |
|
| | |
|
|/ |
|
|
|
|
| |
Relates to #5088 #5114.
|
|
|
|
| |
Relates to #5078 #5147 #5148.
|
|
|
|
|
|
| |
Added on commit ddd7e6fec ("merges", 2022-02-20).
Relates to #4936.
|
|
|
|
|
|
| |
Move the modif entries after the feature entries to be consistent with
the notes of the previous release (0.9.68): features, modifs/reworks,
removals, bugfixes, build, ci, docs, includes/profiles.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.11 to 2.1.12.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/a3a6c128d771b6b9bdebb1c9d0583ebd2728a108...27ea8f8fe5977c00f5b37e076ab846c5bd783b96)
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
|
|\
| |
| | |
mkdeb.sh.in: stop enabling apparmor
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since `make deb-apparmor` already exists, use that for now instead of
changing what `make deb` does.
This fixes CI.
Added on commit 494b26d50 ("adding --enable-apparmor by default for make
deb - most Debian-based distros have apparmor enabled by default",
2022-06-03).
Kind of relates to #5154.
|
|\ \
| |/
|/| |
Revert "I am preparing a point release for next week, fixes and small…
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
of new features. Check in everything you have out."
This reverts commit e8cb03cde8a3a7d083a6f539b06c6253d031af82.
More specifically: s/0.9.68.1/0.9.69/.
The current development version contains not only new features, but also
breaking changes (see "modif:" on the RELNOTES). Ensure at least a
minor (rather than only a patch) version bump (to 0.9.70 on the final
version) to avoid breaking user expectations.
|
|/
|
|
|
|
|
| |
transmission-{gtk,qt} (#5175)
* add comment for enabling desktop notifications
* add comment for enabling desktop notifications
|
| |
|
|
|
|
| |
have apparmor enabled by default
|
|
|
|
| |
features. Check in everything you have out.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
disable-shell.inc: add global shell paths from ids.config
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since /etc/profile is present, add the other shell-related paths in /etc
that are listed on ids.config.
Suggestion by @rusty-snake[1].
Relates to #5167 #5170.
[1] https://github.com/netblue30/firejail/pull/5167#pullrequestreview-989621852
|
| | |
|
| | |
|