aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAge
* private-etc: always reference 'alternatives' (#5517)Libravatar glitsj162022-12-09
| | | | | | | | | * private-etc: always include 'alternatives' * private-etc: always include 'alternatives' * private-etc: always include 'alternatives' * private-etc: always include 'alternatives'
* New profile: tesseract (#5516)Libravatar glitsj162022-12-09
| | | | | | | | | | | | | | | | | | | | | | | * Add firecfg support for tesseract * Add tesseract to 'New profiles' section in README.md * Create tesseract.profile * tesseract: fix private-etc * tesseract: fix XDG black/whitelisting * tesseract: use 'seccomp socket' instead of 'protocol unix' As kindly suggested by @rusty-snake. * tesseract: add 'restrict-namespaces' As kindly suggested by @rusty-snake. * tesseract: use full seccomp filtering The tesseract application works fine without 'protocol' or 'seccomp socket'.
* sandbox.c: print the dir on failed chdir(cfg.homedir)Libravatar Kelvin M. Klann2022-12-09
| | | | | | | | Just like the other nearby error messages for `chdir`. Relates to #5510. Suggested-by: @gitsteff
* Merge pull request #5498 from kmk3/spotify-allow-adblockLibravatar Kelvin M. Klann2022-12-08
|\ | | | | spotify.profile: allow spotify-adblock paths
| * spotify.profile: allow spotify-adblock pathsLibravatar Kelvin M. Klann2022-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As suggested by @glitsj16[1]. Project homepage: https://github.com/abba23/spotify-adblock Configuration paths: * /etc/spotify-adblock/config.toml * ~/.config/spotify-adblock/config.toml Fixes #5494. [1] https://github.com/netblue30/firejail/discussions/5494#discussioncomment-4280887 Reported-by: @Rewig95
* | Merge pull request #5496 from kmk3/kcalc-fix-mkfileLibravatar Kelvin M. Klann2022-12-08
|\ \ | | | | | | kcalc.profile: fix mkfile without mkdir & comment legacy paths
| * | kcalc.profile: stop creating legacy KDE pathsLibravatar Kelvin M. Klann2022-12-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Leave them commented. With this commit, there are no more profiles creating paths in ~/.kde nor in ~/.kde4: $ git grep -e '^mkdir .*\.kde' -e '^mkfile .*\.kde' -- etc $ See also commit 3ef030257 ("ktorrent.profile: stop creating legacy KDE paths", 2022-10-11) / PR #5415.
| * | kcalc.profile: fix mkfile without mkdirLibravatar Kelvin M. Klann2022-12-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | firejail may fail to create the following files: * ~/.kde/share/config/kcalcrc * ~/.kde4/share/config/kcalcrc Because it does not create the preceding directories beforehand: * ~/.kde/share/config * ~/.kde4/share/config See also commit 7f1906dba ("ktorrent.profile: fix mkfile without mkdir", 2022-10-11) / PR #5415.
* | | build(deps): bump github/codeql-action from 2.1.31 to 2.1.35Libravatar dependabot[bot]2022-12-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.31 to 2.1.35. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/c3b6fce4ee2ca25bc1066aa3bf73962fda0e8898...b2a92eb56d8cb930006a1c6ed86b0782dd8a4297) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | Add basic gtksourceview language-spec (#5502)Libravatar rusty-snake2022-12-04
| |/ |/| | | | | | | | | | | Tested with org.gnome.TextEditor. The gtksourceview language-spec hasn't changed between gtksourceview 3, 4 and 5 AFAIK so it should also work on older systems if you copy/link the file in the right places.
* | Merge pull request #5488 from kmk3/configure-fix-format-miscLibravatar Reiner Herrmann2022-12-01
|\ \ | | | | | | build: fix formatting and misc in configure
| * | configure*: quote and line-wrap AC_CHECK_HEADER lineLibravatar Kelvin M. Klann2022-11-28
| | | | | | | | | | | | | | | Misc: I missed this one on commit 221c10177 ("configure*: Add missing quotes to arguments", 2021-06-03) / PR #4712.
| * | configure*: fix quotes/parens alignment (sanitizer)Libravatar Kelvin M. Klann2022-11-28
| | |
| * | configure*: wrap long AS_HELP_STRING line (sanitizer)Libravatar Kelvin M. Klann2022-11-28
| | |
| * | configure*: wrap long shell command output linesLibravatar Kelvin M. Klann2022-11-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of binding them together with conditionals in a single line, split shell commands into multiple lines to make them more readable. Note that for the macro arguments in question, the content inside [] quotes is output literally into ./configure, so the commands can be written as if they were in a shell script directly (save for any special characters/tokens in Autoconf). Misc: Relates to commit 2c64d1fdd ("use AX_CHECK_COMPILE_FLAG to check for spectre flags", 2019-06-21).
| * | configure*: remove extraneous blank lines (warning)Libravatar Kelvin M. Klann2022-11-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added on commit d1acb31c9 ("compile time: enable LTS", 2021-02-28). Note: Do not print a preceding blank line because one is already printed right before the warning message, right after the items on "Features:". Example of the resulting warning message: $ autoconf && ./configure [...] configure: creating ./config.status config.status: creating config.mk config.status: creating config.sh Compile options: [...] prefix: /usr/local sysconfdir: ${prefix}/etc Spectre compiler patch: yes Features: [...] SELinux labeling support: user namespace: -DHAVE_USERNS X11 sandboxing support: -DHAVE_X11 ********************************************************* * Warning: Long-term support (LTS) was enabled! * * Most compile-time options have been rewritten! * ********************************************************* $
| * | configure*: remove extraneous blank linesLibravatar Kelvin M. Klann2022-11-28
| | |
| * | configure*: fix indentationLibravatar Kelvin M. Klann2022-11-28
| | |
| * | configure*: fix trailing comma in HAVE_CONTRIB_INSTALLLibravatar Kelvin M. Klann2022-11-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Consider the current code: AS_IF([test "x$enable_lts" = "xyes"], [ # ... HAVE_CONTRIB_INSTALL="no", Result of testing the value: $ HAVE_CONTRIB_INSTALL="no", $ printf '%s\n' "$HAVE_CONTRIB_INSTALL" no, $ test "x$HAVE_CONTRIB_INSTALL" = "xno" && echo equal || echo 'not equal' not equal This means that whenever HAVE_LTS is enabled, HAVE_CONTRIB_INSTALL is always considered enabled when testing against "no". But luckily, in the current code the latter variable is only tested against "yes", so nothing should be affected: $ git grep HAVE_CONTRIB_INSTALL | grep -v -e '^configure:' -e '^configure.ac:' Makefile:ifeq ($(HAVE_CONTRIB_INSTALL),yes) config.mk.in:HAVE_CONTRIB_INSTALL=@HAVE_CONTRIB_INSTALL@ Added on commit d1acb31c9 ("compile time: enable LTS", 2021-02-28).
| * | configure*: fix typo of "been"Libravatar Kelvin M. Klann2022-11-28
| | | | | | | | | | | | | | | | | | s/bean/been Added on commit d1acb31c9 ("compile time: enable LTS", 2021-02-28).
* | | firefox-common-addons: fix whitelisting in ${RUNUSER} (#5497)Libravatar glitsj162022-12-01
| | | | | | | | | | | | | | | | | | | | | * fix whitelisting in ${RUNUSER} See discussions https://github.com/netblue30/firejail/discussions/5495 for context. * Prevent whitelisting ${RUNUSER} comment
* | | AppArmor: add more examples to firejail-local (#5493)Libravatar glitsj162022-12-01
| |/ |/| | | | | | | * AppArmor: add more examples to firejail-local * comments fixes
* | RELNOTES: add ci and docs itemsLibravatar Kelvin M. Klann2022-11-28
| | | | | | | | Relates to #5189 #5349 #5439 #5485.
* | [firefox-common.profile] Add DRM support when using psd (#5486)Libravatar glitsj162022-11-28
|/
* ci: ignore profile-checks.yml on other workflowsLibravatar Kelvin M. Klann2022-11-28
| | | | | | | | | | To avoid running CI unnecessarily. Misc: I noticed this on commit a42c1de0b ("profile-checks.yml: sort paths-ignore", 2022-11-27). See also commit 768410cf5 ("Run profile-ckeck on workflow edits", 2022-11-27). Relates to #5481.
* profile-checks.yml: sort paths-ignoreLibravatar Kelvin M. Klann2022-11-27
| | | | | See commit 9bf5e453c ("ci: sort items on paths-ignore lists", 2022-07-12) / PR #5481 for details.
* Run profile-ckeck on workflow editsLibravatar rusty-snake2022-11-27
|
* Workflows: Change egress-policy to block (#5485)Libravatar rusty-snake2022-11-27
|
* Workflows: Change egress-policy to blockLibravatar rusty-snake2022-11-26
|
* RELNOTES: add build and ci itemsLibravatar Kelvin M. Klann2022-11-25
| | | | Relates to #5429 #5478 #5481.
* Merge pull request #5415 from kmk3/ktorrent-fix-mkfileLibravatar netblue302022-11-25
|\ | | | | ktorrent.profile: fix mkfile without mkdir & comment legacy paths
| * ktorrent.profile: add missing private-bin pathsLibravatar Kelvin M. Klann2022-11-22
| | | | | | | | | | | | | | | | | | | | | | | | | | Package-provided binaries: $ pacman -Q ktorrent ktorrent 22.08.3-1.2 $ pacman -Qlq ktorrent | grep bin/. /usr/bin/ktmagnetdownloader /usr/bin/ktorrent /usr/bin/ktupnptest Environment: Artix Linux
| * ktorrent.profile: stop creating legacy KDE pathsLibravatar Kelvin M. Klann2022-11-22
| | | | | | | | Leave them commented.
| * ktorrent.profile: fix mkfile without mkdirLibravatar Kelvin M. Klann2022-11-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | firejail fails to create the following files: * ~/.kde/share/config/ktorrentrc * ~/.kde4/share/config/ktorrentrc Because it does not create the preceding directories beforehand: * ~/.kde/share/config * ~/.kde4/share/config Relates to #5414.
* | Merge pull request #5476 from k4leg/fix_pycharmLibravatar netblue302022-11-25
|\ \ | | | | | | fix: PyCharm profiles
| * | fix: PyCharm profilesLibravatar Bogdan Ruslanovich Drozd2022-11-23
| | | | | | | | | | | | | | | | | | | | | Do not use `private-cache`, because PyCharm places in cache directories stuff like spelling dictionary (i. e. if you download spelling dictionary with `private-cache`, on restart PyCharm you need to download spelling dictionary again).
* | | Merge pull request #5478 from kmk3/build-dedup-makefilesLibravatar netblue302022-11-25
|\ \ \ | | | | | | | | build: deduplicate makefiles
| * | | makefiles: organize CFLAGSLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Line-wrap them and make the order of the flags more similar across src/prog.mk and src/so.mk. This should make it easier to see the differences in CFLAGS between both files.
| * | | makefiles: mention variables intended to be used by includersLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | On src/prog.mk and src/so.mk.
| * | | makefiles: add TOCLEAN and TODISTCLEAN variablesLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | So that includers of src/prog.mk or src/so.mk can just define anything extra that needs to be cleaned without having to override the "clean" target (or having to declare a "distclean" target). Example usage: TOCLEAN += foo TODISTCLEAN += bar
| * | | makefiles: rename common.mk to prog.mkLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For clarity, as it is included by the Makefiles that create programs and non-shared-objects, but not by the ones that create shared objects (see src/so.mk). Commands used to move and search and replace: $ git mv src/common.mk src/prog.mk $ git grep -IFlz 'common.mk' -- src | xargs -0 -I '{}' sh -c \ "printf '%s\n' \"\$(sed 's/common.mk/prog.mk/' '{}')\" >'{}'"
| * | | makefiles: deduplicate lib makefiles into so.mkLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following makefiles are nearly identical, except for the main target name and for any extra headers that they might use: * src/libpostexecseccomp/Makefile * src/libtrace/Makefile * src/libtracelog/Makefile So move all of their (duplicated) code into a new src/so.mk file, and add an include of src/so.mk, which leaves only variables, and the includes of config.mk and src/so.mk in place. With this commit, CFLAGS and LDFLAGS are only defined/changed in the following files: * config.mk.in * src/common.mk * src/so.mk
| * | | makefiles: deduplicate main target name into new SO varLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Put the main target name into a new SO variable, put SO into a new TARGET variable, make "all" depend on `$(TARGET)` and replace every other occurrence of the main target name with `$(SO)`. On the makefiles that build shared objects, to make them more similar. With this commit, all of their targets are identical.
| * | | makefiles: deduplicate many makefiles into common.mkLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The makefiles that both build C programs and include src/common.mk are nearly identical, save for the main target name and for any extra headers and objects that they might use. So move all of their (duplicated) code into src/common.mk, which (other than the "lib" target on src/lib/Makefile) leaves only variables and the includes of config.mk and src/common.mk in place.
| * | | makefiles: deduplicate main target name into new PROG varLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Put the main target name into a new PROG variable, put PROG into a new TARGET variable, make "all" depend on `$(TARGET)` and replace every other occurrence of the main target name with `$(PROG)`. On the makefiles that build non-shared objects, to make them more similar. With this commit, all of their targets are identical (except for the extra "lib" target on src/lib/Makefile).
| * | | makefiles: line-wrap MOD_HDRS and MOD_OBJSLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | | | | | For increased readability, list one item per line on lines that are currently longer than 80 characters.
| * | | makefiles: move extra deps into new MOD varsLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To make the makefiles more similar. That is, add the following new variables: * MOD_HDRS * MOD_SRCS * MOD_OBJS And move existing module-specific header and object dependencies into `MOD_HDRS` and `MOD_OBJS`, respectively. `MOD_SRCS` is added mostly for symmetry/consistency. Note: Use `MOD_` as a prefix instead of `EXTRA_` to avoid confusion, as the latter is currently used for global variables (such as `EXTRA_CFLAGS`), as opposed to module-specific variables. Note2: Add them directly into the HDRS/SRCS/OBJS variables to avoid cluttering the existing recipes with an extra variables unnecessarily. This also allows, for example, referencing all of the object dependencies with `$<` if `$(OBJS)` is the first dependency (at least in GNU make). Note3: Since HDRS/SRCS/OBJS use simple assignment (through `:=`), the MOD variables should appear before including src/common.mk (or src/so.mk).
| * | | makefiles: expand HDRS, SRCS and OBJS immediatelyLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use immediate expansion of the right-hand side (with `:=`) to set the variables to the output of the commands rather than to the (text of the) commands themselves. This should prevent deferred/lazy evaluation, which is something that might potentially result in the relevant files being looked up each time that HDRS and SRCS are evaluated. Commands used to search and replace: git grep -Ilz '^SRCS' -- src | xargs -0 -I '{}' \ sh -c "printf '%s\n' \"\$(sed \ -e 's/^HDRS =/HDRS :=/' \ -e 's/^SRCS =/SRCS :=/' \ -e 's/^OBJS =/OBJS :=/' '{}')\" >'{}'"
| * | | makefiles: rename H_FILE_LIST and C_FILE_LISTLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To HDRS and SRCS, respectively. To be more consistent with the OBJS variable. Misc: These names also appear to be more common from the makefiles that I've seen. Commands used to search and replace: git grep -IFlz -e H_FILE_LIST -e C_FILE_LIST -- src | xargs -0 -I '{}' sh -c "printf '%s\n' \"\$(sed \ -e 's/^H_FILE_LIST *=/HDRS =/' \ -e 's/\$(H_FILE_LIST)/\$(HDRS)/g' \ -e 's/^C_FILE_LIST *=/SRCS =/' \ -e 's/\$(C_FILE_LIST:/\$(SRCS:/g' \ '{}')\" >'{}'"
| * | | makefiles: equalize object dependencies in program targetsLibravatar Kelvin M. Klann2022-11-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Compared to the objects that are actually used in a given recipe, some program targets are missing object dependencies, while others appear to have unused object dependencies. Make each of those targets depend on the objects that are actually used when linking. Note: No check was done for extraneous/missing objects when linking; this commit only makes the object dependencies equal to the objects that are linked.
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2024-09-19 15:16:07 +0000