cleanup and some new tests

4 files changed, 14 insertions, 6 deletions

diff --git a/src/firejail/cmdline.c b/src/firejail/cmdline.c
index 517124d9e..48cbaffb7 100644
--- a/src/firejail/cmdline.c
+++ b/src/firejail/cmdline.c
@@ -27,9 +27,9 @@
 #include <errno.h>
 
 int cmdline_length(int argc, char **argv, int index) {
-        int i,j;
+        unsigned i,j;
         int len = 0;
-        int argcnt = argc - index;
+        unsigned argcnt = argc - index;
         bool in_quotes = false;
 
         for (i = 0; i < argcnt; i++) {
@@ -63,8 +63,8 @@ int cmdline_length(int argc, char **argv, int index) {
 }
 
 void quote_cmdline(char *command_line, char *window_title, int len, int argc, char **argv, int index) {
-        int i,j;
-        int argcnt = argc - index;
+        unsigned i,j;
+        unsigned argcnt = argc - index;
         bool in_quotes = false;
         char *ptr1 = command_line;
         char *ptr2 = window_title;
@@ -127,7 +127,7 @@ void quote_cmdline(char *command_line, char *window_title, int len, int argc, ch
                 ptr2 += strlen(ptr2);
         }
 
-        assert(len == strlen(command_line));
+        assert((unsigned) len == strlen(command_line));
 }
 
 void build_cmdline(char **command_line, char **window_title, int argc, char **argv, int index) {
diff --git a/src/firejail/firejail.h b/src/firejail/firejail.h
index 7a538327d..1546dc403 100644
--- a/src/firejail/firejail.h
+++ b/src/firejail/firejail.h
@@ -590,5 +590,8 @@ void appimage_set(const char *appimage_path);
 void appimage_clear(void);
 const char *appimage_getdir(void);
 
+// cmdline.c
+void build_cmdline(char **command_line, char **window_title, int argc, char **argv, int index);
+
 #endif
 
diff --git a/src/firejail/fs_bin.c b/src/firejail/fs_bin.c
index ac731c246..dca66888c 100644
--- a/src/firejail/fs_bin.c
+++ b/src/firejail/fs_bin.c
@@ -136,7 +136,7 @@ void fs_check_bin_list(void) {
                 ptr = strrchr(newlist, ',');
                 assert(ptr);
                 *ptr = '\0';
-                if (notfound)
+                if (notfound && !arg_quiet)
                         fprintf(stderr, "Warning: not all executables from --private-bin list were found. The current list is %s\n", newlist);
                 
                 cfg.bin_private_keep = newlist;
diff --git a/src/firejail/main.c b/src/firejail/main.c
index e86d78ff1..d5ac7ad1d 100644
--- a/src/firejail/main.c
+++ b/src/firejail/main.c
@@ -704,6 +704,11 @@ static void detect_quiet(int argc, char **argv) {
                 "gzip",
                 "xz",
                 "xzdec",
+                "file",
+                "gtar",
+                "tar",
+                "unrar",
+                "unzip",
                 NULL
         };