diff options
author | 2023-05-11 19:14:30 -0300 | |
---|---|---|
committer | 2023-05-14 16:52:46 -0300 | |
commit | a29fd5cac31a634a7859c1b4365a090b636768f7 (patch) | |
tree | 8ba6d1f84e24a04e4ac45752a2c9e70bbe8976df /src | |
parent | firejail: move print_version from checkcfg.c to usage.c (diff) | |
download | firejail-a29fd5cac31a634a7859c1b4365a090b636768f7.tar.gz firejail-a29fd5cac31a634a7859c1b4365a090b636768f7.tar.zst firejail-a29fd5cac31a634a7859c1b4365a090b636768f7.zip |
firejail: deduplicate version printing
Split print_version into two functions:
* print_version: only prints the version line
* print_version_full: also prints compile-time support
Diffstat (limited to 'src')
-rw-r--r-- | src/firejail/firejail.h | 1 | ||||
-rw-r--r-- | src/firejail/main.c | 4 | ||||
-rw-r--r-- | src/firejail/usage.c | 9 |
3 files changed, 9 insertions, 5 deletions
diff --git a/src/firejail/firejail.h b/src/firejail/firejail.h index 7ad7feaf3..d85b470e6 100644 --- a/src/firejail/firejail.h +++ b/src/firejail/firejail.h | |||
@@ -478,6 +478,7 @@ void top(void); | |||
478 | 478 | ||
479 | // usage.c | 479 | // usage.c |
480 | void print_version(void); | 480 | void print_version(void); |
481 | void print_version_full(void); | ||
481 | void usage(void); | 482 | void usage(void); |
482 | 483 | ||
483 | // process.c | 484 | // process.c |
diff --git a/src/firejail/main.c b/src/firejail/main.c index 7e23cdc63..6bb63d26f 100644 --- a/src/firejail/main.c +++ b/src/firejail/main.c | |||
@@ -369,7 +369,7 @@ static void run_cmd_and_exit(int i, int argc, char **argv) { | |||
369 | exit(0); | 369 | exit(0); |
370 | } | 370 | } |
371 | else if (strcmp(argv[i], "--version") == 0) { | 371 | else if (strcmp(argv[i], "--version") == 0) { |
372 | print_version(); | 372 | print_version_full(); |
373 | exit(0); | 373 | exit(0); |
374 | } | 374 | } |
375 | #ifdef HAVE_OVERLAYFS | 375 | #ifdef HAVE_OVERLAYFS |
@@ -1128,7 +1128,7 @@ int main(int argc, char **argv, char **envp) { | |||
1128 | EUID_USER(); | 1128 | EUID_USER(); |
1129 | if (rv == 0) { | 1129 | if (rv == 0) { |
1130 | if (check_arg(argc, argv, "--version", 1)) { | 1130 | if (check_arg(argc, argv, "--version", 1)) { |
1131 | print_version(); | 1131 | print_version_full(); |
1132 | exit(0); | 1132 | exit(0); |
1133 | } | 1133 | } |
1134 | 1134 | ||
diff --git a/src/firejail/usage.c b/src/firejail/usage.c index a41a6fa1f..8ec868fae 100644 --- a/src/firejail/usage.c +++ b/src/firejail/usage.c | |||
@@ -315,13 +315,16 @@ static char *usage_str = | |||
315 | "\n"; | 315 | "\n"; |
316 | 316 | ||
317 | void print_version(void) { | 317 | void print_version(void) { |
318 | printf("firejail version %s\n", VERSION); | 318 | printf("firejail version %s\n\n", VERSION); |
319 | printf("\n"); | 319 | } |
320 | |||
321 | void print_version_full(void) { | ||
322 | print_version(); | ||
320 | print_compiletime_support(); | 323 | print_compiletime_support(); |
321 | printf("\n"); | 324 | printf("\n"); |
322 | } | 325 | } |
323 | 326 | ||
324 | void usage(void) { | 327 | void usage(void) { |
325 | printf("firejail version %s\n\n", VERSION); | 328 | print_version(); |
326 | puts(usage_str); | 329 | puts(usage_str); |
327 | } | 330 | } |