private-bin fixup (#4646)

cannot create fslogger file as user,
so raise privs and create it as root

1 files changed, 4 insertions, 3 deletions

diff --git a/src/firejail/fs_bin.c b/src/firejail/fs_bin.c
index a4c1ff822..4c9dac0c2 100644
--- a/src/firejail/fs_bin.c
+++ b/src/firejail/fs_bin.c
@@ -285,24 +285,25 @@ void fs_private_bin_list(void) {
         while ((ptr = strtok(NULL, ",")) != NULL)
                 globbing(ptr);
         free(dlist);
-        fs_logger_print();
 
         // mount-bind
+        EUID_ROOT();
         int i = 0;
         while (paths[i]) {
                 struct stat s;
                 if (stat(paths[i], &s) == 0) {
                         if (arg_debug)
                                 printf("Mount-bind %s on top of %s\n", RUN_BIN_DIR, paths[i]);
-                        EUID_ROOT();
                         if (mount(RUN_BIN_DIR, paths[i], NULL, MS_BIND|MS_REC, NULL) < 0)
                                 errExit("mount bind");
-                        EUID_USER();
                         fs_logger2("tmpfs", paths[i]);
                         fs_logger2("mount", paths[i]);
                 }
                 i++;
         }
+        fs_logger_print();
+        EUID_USER();
+
         selinux_relabel_path(RUN_BIN_DIR, "/bin");
         fmessage("%d %s installed in %0.2f ms\n", prog_cnt, (prog_cnt == 1)? "program": "programs", timetrace_end());
 }