llvm scan

4 files changed, 8 insertions, 5 deletions

diff --git a/src/firejail/fs_logger.c b/src/firejail/fs_logger.c
index f735b1489..9f742c5bd 100644
--- a/src/firejail/fs_logger.c
+++ b/src/firejail/fs_logger.c
@@ -90,6 +90,7 @@ void fs_logger_print(void) {
         }
         
         int rv = chown(RUN_FSLOGGER_FILE, getuid(), getgid());
+        (void) rv; // best effort!
         rv = chmod(RUN_FSLOGGER_FILE, 0600);
         (void) rv; // best effort!
         
diff --git a/src/firejail/fs_whitelist.c b/src/firejail/fs_whitelist.c
index e0187981b..a584cb69d 100644
--- a/src/firejail/fs_whitelist.c
+++ b/src/firejail/fs_whitelist.c
@@ -390,8 +390,10 @@ void fs_whitelist(void) {
                 // mark symbolic links
                 if (is_link(new_name))
                         entry->link = new_name;
-                else
+                else {
                         free(new_name);
+                        new_name = NULL;
+                }
 
                 // change file name in entry->data
                 if (strcmp(fname, entry->data + 10) != 0) {
diff --git a/src/firejail/network.c b/src/firejail/network.c
index 461946d83..5f7a84a1e 100644
--- a/src/firejail/network.c
+++ b/src/firejail/network.c
@@ -138,8 +138,8 @@ void net_set_mtu(const char *ifname, int mtu) {
         ifr.ifr_addr.sa_family = AF_INET;
         strncpy(ifr.ifr_name, ifname, IFNAMSIZ);
         ifr.ifr_mtu = mtu;
-        if (ioctl(s, SIOCSIFMTU, (caddr_t)&ifr) == 0)
-                mtu = ifr.ifr_mtu;
+        if (ioctl(s, SIOCSIFMTU, (caddr_t)&ifr) != 0)
+                fprintf(stderr, "Warning: cannot set mtu for interface %s\n", ifname);
         close(s);
 }
 
diff --git a/src/libtrace/libtrace.c b/src/libtrace/libtrace.c
index b763213f6..44f0cc4d0 100644
--- a/src/libtrace/libtrace.c
+++ b/src/libtrace/libtrace.c
@@ -490,9 +490,9 @@ int socket(int domain, int type, int protocol) {
 
         str = translate(socket_protocol, protocol);
         if (str == NULL)
-                ptr += sprintf(ptr, "%d", protocol);
+                sprintf(ptr, "%d", protocol);
         else
-                ptr += sprintf(ptr, "%s", str);
+                sprintf(ptr, "%s", str);
 
         printf("%s\n", buf);
         return rv;