Apply --rmenv immediately to help to avoid the env var length check

Remove environment variables with --rmenv immediately. This fixes
removing long environment variables (LS_COLORS generated by vivid),
previously the length filter would trip before the command was
processed.

This changes user visible behavior slightly, for example --rmenv=LANG
now applies also to Firejail, while earlier it would only apply to
sandboxed program.

Partially fixes #3673, but not handling `rmenv` in profiles.

Also suggest --rmenv when there are problems with enviroment
variables.

Signed-off-by: Topi Miettinen <toiwoton@gmail.com>

1 files changed, 1 insertions, 0 deletions

diff --git a/src/firejail/profile.c b/src/firejail/profile.c
index 8c29fe81c..ed736521a 100644
--- a/src/firejail/profile.c
+++ b/src/firejail/profile.c
@@ -912,6 +912,7 @@ int profile_check_line(char *ptr, int lineno, const char *fname) {
                 return 0;
         }
         if (strncmp(ptr, "rmenv ", 6) == 0) {
+                unsetenv(ptr + 6); // Remove also immediately from Firejail itself
                 env_store(ptr + 6, RMENV);
                 return 0;
         }