diff options
author | Glenn Washburn <development@efficientek.com> | 2019-08-29 22:08:25 -0500 |
---|---|---|
committer | Glenn Washburn <development@efficientek.com> | 2019-08-29 22:08:25 -0500 |
commit | 02580c890f28766ffef0b9aa8d4f17fd7b8ab905 (patch) | |
tree | 4716699151261c2584d8a910e1035a5d2581b3e8 /src/fbuilder/build_profile.c | |
parent | Update man page to note that --trace can now take an optional parameter. (diff) | |
download | firejail-02580c890f28766ffef0b9aa8d4f17fd7b8ab905.tar.gz firejail-02580c890f28766ffef0b9aa8d4f17fd7b8ab905.tar.zst firejail-02580c890f28766ffef0b9aa8d4f17fd7b8ab905.zip |
When running builder trace output should go to separate file because (1) trace output is logged to console, which is a pain to capture, and (2) it should not be mingled with program output anyway, which it was when sending to stdout.
Diffstat (limited to 'src/fbuilder/build_profile.c')
-rw-r--r-- | src/fbuilder/build_profile.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/fbuilder/build_profile.c b/src/fbuilder/build_profile.c index 5199829d7..a0f71ae03 100644 --- a/src/fbuilder/build_profile.c +++ b/src/fbuilder/build_profile.c | |||
@@ -61,7 +61,7 @@ void build_profile(int argc, char **argv, int index, FILE *fp) { | |||
61 | 61 | ||
62 | char *output; | 62 | char *output; |
63 | char *stroutput; | 63 | char *stroutput; |
64 | if(asprintf(&output,"--output=%s",trace_output) == -1) | 64 | if(asprintf(&output,"--trace=%s",trace_output) == -1) |
65 | errExit("asprintf"); | 65 | errExit("asprintf"); |
66 | if(asprintf(&stroutput,"-o%s",strace_output) == -1) | 66 | if(asprintf(&stroutput,"-o%s",strace_output) == -1) |
67 | errExit("asprintf"); | 67 | errExit("asprintf"); |
@@ -69,11 +69,10 @@ void build_profile(int argc, char **argv, int index, FILE *fp) { | |||
69 | char *cmdlist[] = { | 69 | char *cmdlist[] = { |
70 | BINDIR "/firejail", | 70 | BINDIR "/firejail", |
71 | "--quiet", | 71 | "--quiet", |
72 | output, | ||
73 | "--noprofile", | 72 | "--noprofile", |
74 | "--caps.drop=all", | 73 | "--caps.drop=all", |
75 | "--nonewprivs", | 74 | "--nonewprivs", |
76 | "--trace", | 75 | output, |
77 | "--shell=none", | 76 | "--shell=none", |
78 | "/usr/bin/strace", // also used as a marker in build_profile() | 77 | "/usr/bin/strace", // also used as a marker in build_profile() |
79 | "-c", | 78 | "-c", |