aboutsummaryrefslogtreecommitdiffstats
path: root/etc/inc/whitelist-1793-workaround.inc
diff options
context:
space:
mode:
authorLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2021-07-18 20:39:14 -0300
committerLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2021-07-18 20:39:14 -0300
commitf43382f1e9707b4fd5e63c7bfe881912aa4ee994 (patch)
tree499639bb962c8b071b153dcdad1b42af8286521d /etc/inc/whitelist-1793-workaround.inc
parentAdd MS Edge Beta profile (diff)
downloadfirejail-f43382f1e9707b4fd5e63c7bfe881912aa4ee994.tar.gz
firejail-f43382f1e9707b4fd5e63c7bfe881912aa4ee994.tar.zst
firejail-f43382f1e9707b4fd5e63c7bfe881912aa4ee994.zip
Revert "move whitelist/blacklist to allow/deny"
This reverts commit fe0f975f447d59977d90c3226cc8c623b31b20b3. Note: This only reverts the changes from etc. The 4 aliases introduced on commit 45f2ba544 are mere, well, aliases. That is, they fail to address the different usability problems discussed on [#3447][3447] and in fact only make things more confusing (as has already been mentioned on [this][4379] and later comments). The main reason is that the aliases do not meaningfully map to the original commands. For example, the commands from each pair below seem like they would do the exact same thing: * `allow` and `nodeny` * `deny` and `noallow` Additionally, if these aliases are not the final commands, but only a test/work-in-progress, then keeping the wide-scale search/replace changes made on commit fe0f975f4 would only serve to cause confusion, as users of firejail-git, contributors and downstream projects might start changing the commands used on their profiles, only to later have to change them again, potentially to completely different commands. The sooner this is undone the better, as (besides the above reasons) the more profile changes there are between the original commit and the revert, the harder it is to e.g.: `git diff` versions of files across the following revision ranges: before the commit, after the commit but before the revert and after the revert. Note: This is still the case even if a commit is [ignored by `git blame`][4390]. So let us revert fe0f975f4 and only reapply similar large-scale changes once we have discussed and settled on better commands. How the revert was applied: Despite using the auto-generated message from `git revert`, to ensure correctness and to avoid conflicts the changes were reverted in different steps: Firstly, revert the files which can be safely reverted directly ("filestorevert"): # Find out which files have been changed on fe0f975f44, but have not # been changed afterwards and list them on "filestorevert" git show --pretty='' --name-only fe0f975f44 -- etc | LC_ALL=C sort >allfiles git diff --name-only fe0f975f44..master -- etc | LC_ALL=C sort >filestoignore comm -2 -3 allfiles filestoignore >filestorevert # Note: There are 3 extra files on filestoignore because they were # added after commit fe0f975f44 wc -l allfiles filestoignore filestorevert | head -n 3 # 797 allfiles # 8 filestoignore # 792 filestorevert # Automatically revert files in "filestorevert" # See https://stackoverflow.com/a/23401018/10095231 tr '\n' '\000' <filestorevert | xargs -0 git show fe0f975f44 -- | git apply --reverse printf 'Total files reverted:\n' git diff --name-only | wc -l # 792 Secondly, do some search/replace on the rest: tr '\n' '\000' <filestoignore | xargs -0 sed -i.bak \ -e 's/allow /whitelist /' -e 's/noallow /nowhitelist /' \ -e 's/deny /blacklist /' -e 's/nodeny /noblacklist /' \ -e 's/deny-nolog /blacklist-nolog /' find etc -name '*.bak' -print0 | xargs -0 rm Thirdly, verify the result. The following command shows the difference between all the changes in etc from before fe0f975f44 and this commit (inclusive): git diff fe0f975f44~1 -- etc From the output, it looks like all alias changes are fully reverted and that the other changes to etc (from after fe0f975f44) remain, so the revert seems to be done correctly. [3447]: https://github.com/netblue30/firejail/issues/3447 [4379]: https://github.com/netblue30/firejail/issues/4379#issuecomment-876460222 [4390]: https://github.com/netblue30/firejail/issues/4390
Diffstat (limited to 'etc/inc/whitelist-1793-workaround.inc')
-rw-r--r--etc/inc/whitelist-1793-workaround.inc46
1 files changed, 23 insertions, 23 deletions
diff --git a/etc/inc/whitelist-1793-workaround.inc b/etc/inc/whitelist-1793-workaround.inc
index 06a424440..862837f12 100644
--- a/etc/inc/whitelist-1793-workaround.inc
+++ b/etc/inc/whitelist-1793-workaround.inc
@@ -3,27 +3,27 @@
3include whitelist-1793-workaround.local 3include whitelist-1793-workaround.local
4# This works around bug 1793, and allows whitelisting to be used for some KDE applications. 4# This works around bug 1793, and allows whitelisting to be used for some KDE applications.
5 5
6nodeny ${HOME}/.config/ibus 6noblacklist ${HOME}/.config/ibus
7nodeny ${HOME}/.config/mimeapps.list 7noblacklist ${HOME}/.config/mimeapps.list
8nodeny ${HOME}/.config/pkcs11 8noblacklist ${HOME}/.config/pkcs11
9nodeny ${HOME}/.config/user-dirs.dirs 9noblacklist ${HOME}/.config/user-dirs.dirs
10nodeny ${HOME}/.config/user-dirs.locale 10noblacklist ${HOME}/.config/user-dirs.locale
11nodeny ${HOME}/.config/dconf 11noblacklist ${HOME}/.config/dconf
12nodeny ${HOME}/.config/fontconfig 12noblacklist ${HOME}/.config/fontconfig
13nodeny ${HOME}/.config/gtk-2.0 13noblacklist ${HOME}/.config/gtk-2.0
14nodeny ${HOME}/.config/gtk-3.0 14noblacklist ${HOME}/.config/gtk-3.0
15nodeny ${HOME}/.config/gtk-4.0 15noblacklist ${HOME}/.config/gtk-4.0
16nodeny ${HOME}/.config/gtkrc 16noblacklist ${HOME}/.config/gtkrc
17nodeny ${HOME}/.config/gtkrc-2.0 17noblacklist ${HOME}/.config/gtkrc-2.0
18nodeny ${HOME}/.config/Kvantum 18noblacklist ${HOME}/.config/Kvantum
19nodeny ${HOME}/.config/Trolltech.conf 19noblacklist ${HOME}/.config/Trolltech.conf
20nodeny ${HOME}/.config/QtProject.conf 20noblacklist ${HOME}/.config/QtProject.conf
21nodeny ${HOME}/.config/kdeglobals 21noblacklist ${HOME}/.config/kdeglobals
22nodeny ${HOME}/.config/kio_httprc 22noblacklist ${HOME}/.config/kio_httprc
23nodeny ${HOME}/.config/kioslaverc 23noblacklist ${HOME}/.config/kioslaverc
24nodeny ${HOME}/.config/ksslcablacklist 24noblacklist ${HOME}/.config/ksslcablacklist
25nodeny ${HOME}/.config/qt5ct 25noblacklist ${HOME}/.config/qt5ct
26nodeny ${HOME}/.config/qtcurve 26noblacklist ${HOME}/.config/qtcurve
27 27
28deny ${HOME}/.config/* 28blacklist ${HOME}/.config/*
29allow ${HOME}/.config 29whitelist ${HOME}/.config