build: automatically generate header dependencies

Instead of manually specifying which source files depend on which
headers, use compiler flags to automatically generate depfiles (.d),
which declare the correct header (make) dependencies for each source
file (.c).

Use `-MMD` (which ignores system headers) to generate the dependencies
and `-MP` to prevent make from complaining when a header file is removed
while it is listed as a dependency in a depfile.

If depfiles exist, just include them.  If not, make each object file
(.o) unconditionally depend on all header files in its source directory
and in src/include, to ensure that rebuilds are done when needed.  The
latter case applies to the first build after `make clean` (which would
build everything anyway) and when the compiler does not support
generating depfiles.

Note that both gcc and clang have supported these options for a long
time.

Misc: This depends on the changes from commit 5b1bd33c7 ("build: use
full paths on compile/link targets", 2023-07-02) / PR #6158 to avoid
issues with make dependency tracking.

1 files changed, 5 insertions, 2 deletions

diff --git a/config.mk.in b/config.mk.in
index 63d7fb981..1521a2633 100644
--- a/config.mk.in
+++ b/config.mk.in
@@ -81,6 +81,7 @@ LDFLAGS=@LDFLAGS@
 
 # Project variables
 EXTRA_CFLAGS  =@EXTRA_CFLAGS@
+DEPS_CFLAGS   =@DEPS_CFLAGS@
 COMMON_CFLAGS = \
         -ggdb -O2 -DVERSION='"$(VERSION)"' \
         -Wall -Wextra $(HAVE_FATAL_WARNINGS) \
@@ -88,16 +89,18 @@ COMMON_CFLAGS = \
         -fstack-protector-all -D_FORTIFY_SOURCE=2 \
         -DPREFIX='"$(prefix)"' -DSYSCONFDIR='"$(sysconfdir)/firejail"' \
         -DLIBDIR='"$(libdir)"' -DBINDIR='"$(bindir)"' \
-        -DVARDIR='"/var/lib/firejail"' \
+        -DVARDIR='"/var/lib/firejail"'
 
 PROG_CFLAGS = \
         $(COMMON_CFLAGS) \
         $(HAVE_GCOV) $(MANFLAGS) \
         $(EXTRA_CFLAGS) \
+        $(DEPS_CFLAGS) \
         -fPIE
 
 SO_CFLAGS = \
         $(COMMON_CFLAGS) \
+        $(DEPS_CFLAGS) \
         -fPIC
 
 EXTRA_LDFLAGS =@EXTRA_LDFLAGS@
@@ -105,4 +108,4 @@ PROG_LDFLAGS  = -Wl,-z,relro -Wl,-z,now -fPIE -pie $(EXTRA_LDFLAGS)
 SO_LDFLAGS    = -Wl,-z,relro -Wl,-z,now -fPIC
 LIBS =@LIBS@
 
-CLEANFILES = *.o *.gcov *.gcda *.gcno *.plist
+CLEANFILES = *.d *.o *.gcov *.gcda *.gcno *.plist