makefiles: add generated files as dependencies

With the previous commit ("makefiles: stop failing when config.mk does
not exist", 2022-06-23), make will not immediately fail when trying to
build a target without having the proper compile-time flags (which are
defined on common.mk).

For example, when running the command below:

    make distclean && make

It will throw an error only after (mis-)compiling multiple objects.

So add a dependency on config.mk on every target that uses output
variables (such as @NAME@ / $(NAME)) on its recipe.  And add a
dependency on config.sh on targets that call shell scripts that use
output variables (such as @NAME@ / $NAME).  Also, add a recipe for
config.mk / config.sh telling to run ./configure, to make it a bit more
obvious just in case.

With this commit, make will abort earlier, by detecting that the
config.mk / config.sh dependency does not exist.  This happens before
trying to execute the recipe.

This also makes the dependencies more accurate, since if config.mk
(which defines some CFLAGS) is changed, the CFLAGS may also have
changed, so a target that uses CFLAGS should probably be considered out
of date in this case anyway.

Relates to #5140.

1 files changed, 14 insertions, 9 deletions

diff --git a/Makefile b/Makefile
index 5d14ce467..11e19ec37 100644
--- a/Makefile
+++ b/Makefile
@@ -21,6 +21,10 @@ MANPAGES = firejail.1 firemon.1 firecfg.1 firejail-profile.5 firejail-login.5 fi
 SECCOMP_FILTERS = seccomp seccomp.debug seccomp.32 seccomp.block_secondary seccomp.mdwx seccomp.mdwx.32
 ALL_ITEMS = $(APPS) $(SBOX_APPS) $(SBOX_APPS_NON_DUMPABLE) $(MYLIBS)
 
+config.mk config.sh:
+        printf 'run ./configure to generate %s\n' "$@" >&2
+        false
+
 .PHONY: all_items $(ALL_ITEMS)
 all_items: $(ALL_ITEMS)
 $(ALL_ITEMS): $(MYDIRS)
@@ -31,7 +35,7 @@ mydirs: $(MYDIRS)
 $(MYDIRS):
         $(MAKE) -C $@
 
-$(MANPAGES): src/man
+$(MANPAGES): src/man config.mk
         ./mkman.sh $(VERSION) src/man/$(basename $@).man $@
 
 man: $(MANPAGES)
@@ -87,7 +91,7 @@ distclean: clean
         $(MAKE) -C test distclean
         rm -fr autom4te.cache config.log config.mk config.sh config.status
 
-realinstall:
+realinstall: config.mk
         # firejail executable
         install -m 0755 -d $(DESTDIR)$(bindir)
         install -m 0755 src/firejail/firejail $(DESTDIR)$(bindir)
@@ -171,7 +175,7 @@ install-strip: all
         strip $(ALL_ITEMS)
         $(MAKE) realinstall
 
-uninstall:
+uninstall: config.mk
         rm -f $(DESTDIR)$(bindir)/firejail
         rm -f $(DESTDIR)$(bindir)/firemon
         rm -f $(DESTDIR)$(bindir)/firecfg
@@ -208,7 +212,7 @@ src
 
 DISTFILES_TEST = test/Makefile test/apps test/apps-x11 test/apps-x11-xorg test/root test/private-lib test/fnetfilter test/fcopy test/environment test/profiles test/utils test/compile test/filters test/network test/fs test/sysutils test/chroot
 
-dist:
+dist: config.mk
         mv config.sh config.sh.old
         mv config.status config.status.old
         make distclean
@@ -223,19 +227,20 @@ dist:
         tar -cJvf $(NAME)-$(VERSION).tar.xz $(NAME)-$(VERSION)
         rm -fr $(NAME)-$(VERSION)
 
-asc:; ./mkasc.sh $(VERSION)
+asc: config.mk
+        ./mkasc.sh $(VERSION)
 
-deb: dist
+deb: dist config.sh
         ./mkdeb.sh
 
-deb-apparmor: dist
+deb-apparmor: dist config.sh
         ./mkdeb.sh -apparmor --enable-apparmor
 
-test-compile: dist
+test-compile: dist config.mk
         cd test/compile; ./compile.sh $(NAME)-$(VERSION)
 
 .PHONY: rpms
-rpms: src/man
+rpms: src/man config.mk
         ./platform/rpm/mkrpm.sh $(NAME) $(VERSION)
 
 extras: all