diff options
| author |  Reiner Herrmann <reiner@reiner-h.de> | 2019-06-21 18:26:48 +0200 |
|---|---|---|
| committer | Reiner Herrmann <reiner@reiner-h.de> | 2019-06-21 18:32:13 +0200 |
| commit | 6229979035b93de8616700acfca0b2de4334e693 (patch) | |
| tree | ef28c6ac89e45dee24deebba5a23851251d56dd2 | |
| parent | fix indentation (diff) | |
| download | firejail-6229979035b93de8616700acfca0b2de4334e693.tar.gz firejail-6229979035b93de8616700acfca0b2de4334e693.tar.zst firejail-6229979035b93de8616700acfca0b2de4334e693.zip | |
enable additional cppchecks and fix a warning
| -rw-r--r-- | Makefile.in | 2 | ||||
| -rw-r--r-- | src/firejail/arp.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/Makefile.in b/Makefile.in index af57f7d2c..9d0dd69b1 100644 --- a/Makefile.in +++ b/Makefile.in | |||
| @@ -233,7 +233,7 @@ extras: all | |||
| 233 | $(MAKE) -C extras/firetools | 233 | $(MAKE) -C extras/firetools |
| 234 | 234 | ||
| 235 | cppcheck: clean | 235 | cppcheck: clean |
| 236 | cppcheck --force . | 236 | cppcheck -q --force --error-exitcode=1 --enable=warning,performance . |
| 237 | 237 | ||
| 238 | scan-build: clean | 238 | scan-build: clean |
| 239 | scan-build make | 239 | scan-build make |
diff --git a/src/firejail/arp.c b/src/firejail/arp.c index 06a619ba9..843d00ce0 100644 --- a/src/firejail/arp.c +++ b/src/firejail/arp.c | |||
| @@ -45,7 +45,7 @@ typedef struct arp_hdr_t { | |||
| 45 | void arp_announce(const char *dev, Bridge *br) { | 45 | void arp_announce(const char *dev, Bridge *br) { |
| 46 | // RFC 5227 - using a source and destination IP address of the interface | 46 | // RFC 5227 - using a source and destination IP address of the interface |
| 47 | uint32_t srcaddr = br->ipsandbox; | 47 | uint32_t srcaddr = br->ipsandbox; |
| 48 | uint32_t destaddr = br->ipsandbox; | 48 | uint32_t destaddr = srcaddr; |
| 49 | 49 | ||
| 50 | if (strlen(dev) > IFNAMSIZ) { | 50 | if (strlen(dev) > IFNAMSIZ) { |
| 51 | fprintf(stderr, "Error: invalid network device name %s\n", dev); | 51 | fprintf(stderr, "Error: invalid network device name %s\n", dev); |