little tweak

1 files changed, 3 insertions, 4 deletions

diff --git a/src/firejail/main.c b/src/firejail/main.c
index 435c04d76..6170806f9 100644
--- a/src/firejail/main.c
+++ b/src/firejail/main.c
@@ -1500,15 +1500,14 @@ int main(int argc, char **argv) {
                                         cfg.chrootdir = tmp;
                                 }
 
-                                // check chroot dirname exists
-                                if (strstr(cfg.chrootdir, "..") || !is_dir(cfg.chrootdir) || is_link(cfg.chrootdir)) {
+                                if (strstr(cfg.chrootdir, "..") || is_link(cfg.chrootdir)) {
                                         fprintf(stderr, "Error: invalid chroot directory %s\n", cfg.chrootdir);
                                         return 1;
                                 }
 
-                                // don't allow "--chroot=/"
+                                // check chroot dirname exists, don't allow "--chroot=/"
                                 char *rpath = realpath(cfg.chrootdir, NULL);
-                                if (rpath == NULL || strcmp(rpath, "/") == 0) {
+                                if (rpath == NULL || !is_dir(rpath) || strcmp(rpath, "/") == 0) {
                                         fprintf(stderr, "Error: invalid chroot directory\n");
                                         exit(1);
                                 }