summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLibravatar netblue30 <netblue30@yahoo.com>2017-01-06 22:45:11 -0500
committerLibravatar netblue30 <netblue30@yahoo.com>2017-01-06 22:45:11 -0500
commit5d43fdcd215203868d440ffc42036f5f5ffc89fc (patch)
treed49fd109d7671c7cab636ab62b0561a3e2d53f3a
parentspelling (diff)
downloadfirejail-5d43fdcd215203868d440ffc42036f5f5ffc89fc.tar.gz
firejail-5d43fdcd215203868d440ffc42036f5f5ffc89fc.tar.zst
firejail-5d43fdcd215203868d440ffc42036f5f5ffc89fc.zip
security fix
-rw-r--r--RELNOTES1
-rw-r--r--src/firejail/bandwidth.c9
2 files changed, 2 insertions, 8 deletions
diff --git a/RELNOTES b/RELNOTES
index 969eecb24..b9a982d77 100644
--- a/RELNOTES
+++ b/RELNOTES
@@ -1,5 +1,6 @@
1firejail (0.9.45) baseline; urgency=low 1firejail (0.9.45) baseline; urgency=low
2 * development version, work in progress 2 * development version, work in progress
3 * security: --bandwidth root shel found by Martin Carpenter
3 * security: disabled --allow-debuggers when running on kernel 4 * security: disabled --allow-debuggers when running on kernel
4 versions prior to 4.8; a kernel bug in ptrace system call 5 versions prior to 4.8; a kernel bug in ptrace system call
5 allows a full bypass of seccomp filter; problem reported by Lizzie Dixon 6 allows a full bypass of seccomp filter; problem reported by Lizzie Dixon
diff --git a/src/firejail/bandwidth.c b/src/firejail/bandwidth.c
index 5e9002f22..84c9dc53a 100644
--- a/src/firejail/bandwidth.c
+++ b/src/firejail/bandwidth.c
@@ -435,15 +435,8 @@ void bandwidth_pid(pid_t pid, const char *command, const char *dev, int down, in
435 if (setregid(0, 0)) 435 if (setregid(0, 0))
436 errExit("setregid"); 436 errExit("setregid");
437 437
438 if (!cfg.shell)
439 cfg.shell = guess_shell();
440 if (!cfg.shell) {
441 fprintf(stderr, "Error: no POSIX shell found, please use --shell command line option\n");
442 exit(1);
443 }
444
445 char *arg[4]; 438 char *arg[4];
446 arg[0] = cfg.shell; 439 arg[0] = "/bin/sh";
447 arg[1] = "-c"; 440 arg[1] = "-c";
448 arg[2] = cmd; 441 arg[2] = cmd;
449 arg[3] = NULL; 442 arg[3] = NULL;