diff options
| author |  rusty-snake <print_hello_world+Public@protonmail.com> | 2019-06-24 17:13:29 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2019-06-24 17:13:29 +0000 |
| commit | 85e664520271128110718cc741579587b3917048 (patch) | |
| tree | d6f73acb1f61d93dc9a5ff6c7812010082201bb3 /.github | |
| parent | disable firetunnel at config time (#2793) (diff) | |
| download | firejail-85e664520271128110718cc741579587b3917048.tar.gz firejail-85e664520271128110718cc741579587b3917048.tar.zst firejail-85e664520271128110718cc741579587b3917048.zip | |
* add contrib/sort.py and .github/pull_request_temp…
* Add usage to sort.py
* Install sort.py if contrib-install is set
* sort.py: 0644 -> 0755
* Update sort.py
* Update pull_request_template.md
* Remove checkboxes from PR-Template
* Update sort.py
* Add examples to sort.py
* Update pull_request_template.md
Fix path to sort.py, it depend on the distro.
* Update pull_request_template.md
* Update pull_request_template.md
add hint about template
Diffstat (limited to '.github')
| -rw-r--r-- | .github/pull_request_template.md | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..28ee1c436 --- /dev/null +++ b/.github/pull_request_template.md | |||
| @@ -0,0 +1,17 @@ | |||
| 1 | If you make a PR for new profiles or changeing profiles please do the following: | ||
| 2 | - The ordering of options follow the rules descripted in [/usr/share/doc/firejail/profile.template](https://github.com/netblue30/firejail/blob/master/etc/templates/profile.template). | ||
| 3 | Hint: The profile-template is very new, if you install firejail with your package-manager, it maybe missing, therefore, and to follow the latest rules, it is recommended to use the template from the repository. | ||
| 4 | - Order the arguments of options alphabetical, you can easy do this with the [sort.py](https://github.com/netblue30/firejail/tree/master/contrib/sort.py). | ||
| 5 | The path to it depends on your distro: | ||
| 6 | |||
| 7 | | Distro | Path | | ||
| 8 | | ------ | ---- | | ||
| 9 | | Arch/Fedora | `/lib64/firejail/sort.py` | | ||
| 10 | | Debian/Ubuntu/Mint | `/usr/lib/x86_64-linux-gnu/firejail/sort.py` | | ||
| 11 | | local git clone | `contrib/sort.py` | | ||
| 12 | |||
| 13 | Note also that the sort.py script exists only since firejail `0.9.61`. | ||
| 14 | |||
| 15 | If you have no idea how to do one of these, you can open the PR anyway. | ||
| 16 | |||
| 17 | See also [CONTRIBUTING.md](/CONTRIBUTING.md). | ||