summaryrefslogtreecommitdiffstats
path: root/.github
diff options
context:
space:
mode:
authorLibravatar rusty-snake <print_hello_world+Public@protonmail.com>2019-07-28 22:27:45 +0200
committerLibravatar rusty-snake <print_hello_world+Public@protonmail.com>2019-07-28 22:27:45 +0200
commit84cb87e0e534982f7d29f5971794767a8ab6f478 (patch)
tree45eb8bc5ebe30372fb67fcad9e8a96ae6eeac288 /.github
parentfix ghostwriter (diff)
downloadfirejail-84cb87e0e534982f7d29f5971794767a8ab6f478.tar.gz
firejail-84cb87e0e534982f7d29f5971794767a8ab6f478.tar.zst
firejail-84cb87e0e534982f7d29f5971794767a8ab6f478.zip
Update pull_request_template.md
Diffstat (limited to '.github')
-rw-r--r--.github/pull_request_template.md9
1 files changed, 5 insertions, 4 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index f0e4dd416..71791c000 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -1,17 +1,18 @@
1
2If your PR isn't about profiles or you have no idea how to do one of these, skip the following and go ahead with this PR.
3
1If you make a PR for new profiles or changeing profiles please do the following: 4If you make a PR for new profiles or changeing profiles please do the following:
2 - The ordering of options follow the rules descripted in [/usr/share/doc/firejail/profile.template](https://github.com/netblue30/firejail/blob/master/etc/templates/profile.template). 5 - The ordering of options follow the rules descripted in [/usr/share/doc/firejail/profile.template](https://github.com/netblue30/firejail/blob/master/etc/templates/profile.template).
3 Hint: The profile-template is very new, if you install firejail with your package-manager, it maybe missing, therefore, and to follow the latest rules, it is recommended to use the template from the repository. 6 > Hint: The profile-template is very new, if you install firejail with your package-manager, it maybe missing, therefore, and to follow the latest rules, it is recommended to use the template from the repository.
4 - Order the arguments of options alphabetical, you can easy do this with the [sort.py](https://github.com/netblue30/firejail/tree/master/contrib/sort.py). 7 - Order the arguments of options alphabetical, you can easy do this with the [sort.py](https://github.com/netblue30/firejail/tree/master/contrib/sort.py).
5 The path to it depends on your distro: 8 The path to it depends on your distro:
6 9
7 | Distro | Path | 10 | Distro | Path |
8 | ------ | ---- | 11 | ------ | ---- |
9 | Arch/Fedora | `/lib64/firejail/sort.py` | 12 | Arch/Fedora | `/usr/lib64/firejail/sort.py` |
10 | Debian/Ubuntu/Mint | `/usr/lib/x86_64-linux-gnu/firejail/sort.py` | 13 | Debian/Ubuntu/Mint | `/usr/lib/x86_64-linux-gnu/firejail/sort.py` |
11 | local git clone | `contrib/sort.py` | 14 | local git clone | `contrib/sort.py` |
12 15
13 Note also that the sort.py script exists only since firejail `0.9.61`. 16 Note also that the sort.py script exists only since firejail `0.9.61`.
14 17
15If you have no idea how to do one of these, you can open the PR anyway.
16
17See also [CONTRIBUTING.md](/CONTRIBUTING.md). 18See also [CONTRIBUTING.md](/CONTRIBUTING.md).