From dc8ff86d2f1461f1dd1f8316908a1eb85d059bdf Mon Sep 17 00:00:00 2001 From: Amine Mouafik Date: Thu, 28 Nov 2019 17:55:35 +0700 Subject: #13 Remove uneccessary validation on service update --- app/Controllers/Http/ServiceController.js | 11 ----------- 1 file changed, 11 deletions(-) (limited to 'app') diff --git a/app/Controllers/Http/ServiceController.js b/app/Controllers/Http/ServiceController.js index 4a4a8c4..90055b6 100644 --- a/app/Controllers/Http/ServiceController.js +++ b/app/Controllers/Http/ServiceController.js @@ -179,17 +179,6 @@ class ServiceController { }); } else { // Update service info - const validation = await validateAll(request.all(), { - name: 'required', - }); - if (validation.fails()) { - return response.status(401).send({ - message: 'Invalid POST arguments', - messages: validation.messages(), - status: 401, - }); - } - const data = request.all(); const { id, -- cgit v1.2.3-54-g00ecf From 36ccd2fd3c3b53ca5d269314282579cf01acb907 Mon Sep 17 00:00:00 2001 From: Amine Mouafik Date: Fri, 29 Nov 2019 16:51:45 +0700 Subject: #17 Return HTTP 404 when no announcements available --- app/Controllers/Http/StaticController.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app') diff --git a/app/Controllers/Http/StaticController.js b/app/Controllers/Http/StaticController.js index 2e424e1..5b8d716 100644 --- a/app/Controllers/Http/StaticController.js +++ b/app/Controllers/Http/StaticController.js @@ -234,7 +234,7 @@ class StaticController { if (await fs.pathExists(announcement)) { return response.download(announcement); } - return response.send('No announcement found.'); + return response.status(404).send('No announcement found.'); } } -- cgit v1.2.3-54-g00ecf