Add validations

1 files changed, 30 insertions, 3 deletions

diff --git a/app/Controllers/Http/UserController.js b/app/Controllers/Http/UserController.js
index 5c4d7fb..f81a0d5 100644
--- a/app/Controllers/Http/UserController.js
+++ b/app/Controllers/Http/UserController.js
@@ -1,6 +1,9 @@
 'use strict'
 
 const User = use('App/Models/User');
+const {
+  validateAll
+} = use('Validator');
 const atob = require('atob');
 
 class UserController {
@@ -12,8 +15,22 @@ class UserController {
     auth,
     session
   }) {
+    // Validate user input
+    const validation = await validateAll(request.all(), {
+      firstname: 'required',
+      email: 'required|email|unique:users,email',
+      password: 'required'
+    });
+    if (validation.fails()) {
+      return response.status(401).send({
+        "message": "Invalid POST arguments",
+        "status": 401
+      })
+    }
+
     const data = request.only(['firstname', 'email', 'password']);
 
+    // Create user in DB
     let user;
     try {
       user = await User.create({
@@ -21,13 +38,14 @@ class UserController {
         password: data.password,
         username: data.firstname
       });
-    } catch(e) {
+    } catch (e) {
       return response.status(401).send({
         "message": "E-Mail Address already in use",
         "status": 401
       })
     }
-    
+
+    // Generate new auth token
     const token = await auth.generate(user)
 
     return response.send({
@@ -42,8 +60,17 @@ class UserController {
     response,
     auth
   }) {
+    if (!request.header('Authorization')) {
+      return response.status(401).send({
+        "message": "Please provide authorization",
+        "status": 401
+      })
+    }
+
+    // Get auth data from auth token
     const authHeader = atob(request.header('Authorization').replace('Basic ', '')).split(':');
 
+    // Check if user with email exists
     let user = (await User.query().where('email', authHeader[0]).first());
     if (!user || !user.email) {
       return response.status(401).send({
@@ -53,7 +80,7 @@ class UserController {
       });
     }
 
-
+    // Try to login
     let token;
     try {
       token = await auth.attempt(user.email, authHeader[1])