From 9b8f01716774a960073e944823ab727cc867a8f6 Mon Sep 17 00:00:00 2001 From: MCMXC <16797721+mcmxcdev@users.noreply.github.com> Date: Wed, 26 Jul 2023 06:29:03 -0600 Subject: chore: improve lint setup (#397) - update eslint config to closely mirror the ones from ferdium-app - add .eslintignore - opt in to eslint `reportUnusedDisableDirectives` config option - remove `trailingComma: all` from `prettier` config which is default in `prettier` v3 - autofix or disable a lot of lint issues throughout codebase - add `volta` configuration to `package.json` to autoload correct `node` and `pnpm` versions - upgrade all `eslint` and `prettier` related dependencies to latest - update lint:fix npm script - reformat touched files with prettier - bumped up minor version for all recipes that have changes - introduced injection of 'service.css' where it was missing in many recipes --------- Co-authored-by: Vijay A --- recipes/workplace/package.json | 2 +- recipes/workplace/webview.js | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'recipes/workplace') diff --git a/recipes/workplace/package.json b/recipes/workplace/package.json index ac9918c..fee0cb2 100644 --- a/recipes/workplace/package.json +++ b/recipes/workplace/package.json @@ -1,7 +1,7 @@ { "id": "workplace", "name": "Workplace", - "version": "1.4.0", + "version": "1.5.0", "license": "MIT", "config": { "serviceURL": "https://{teamId}.workplace.com/chat", diff --git a/recipes/workplace/webview.js b/recipes/workplace/webview.js index 8ee283b..d77cfed 100644 --- a/recipes/workplace/webview.js +++ b/recipes/workplace/webview.js @@ -1,9 +1,9 @@ -const _path = _interopRequireDefault(require('path')); - function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; } +const _path = _interopRequireDefault(require('path')); + module.exports = Ferdium => { const getMessages = () => { let direct = 0; @@ -16,16 +16,16 @@ module.exports = Ferdium => { } if (chatsElement) { - if (!chatsElement.hasAttribute('aria-current')) { + if (chatsElement.hasAttribute('aria-current')) { + direct = document.querySelectorAll( + '[data-pagelet="WorkGalahadChannel"] .uiList [role="gridcell"] [role="button"] .oxk9n0fw', + ).length; + } else { const chatMessages = chatsElement.querySelector('span'); if (chatMessages) { direct = Ferdium.safeParseInt(chatMessages.textContent); } - } else { - direct = document.querySelectorAll( - '[data-pagelet="WorkGalahadChannel"] .uiList [role="gridcell"] [role="button"] .oxk9n0fw', - ).length; } } -- cgit v1.2.3-70-g09d2