From c7ba960cfdfbd3dc17904d10cbc4da1d3998348c Mon Sep 17 00:00:00 2001 From: Vijay A Date: Fri, 13 Aug 2021 09:24:12 +0530 Subject: Added TODOs related to opening child window for screensharing/video calls. --- recipes/skype/webview.js | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'recipes/skype/webview.js') diff --git a/recipes/skype/webview.js b/recipes/skype/webview.js index f8b4d7b..c20726c 100644 --- a/recipes/skype/webview.js +++ b/recipes/skype/webview.js @@ -35,12 +35,17 @@ module.exports = (Franz, settings) => { if (url.includes('views/imgpsh_fullsize_anim')) { event.preventDefault(); event.stopPropagation(); + // TODO: Can we send an ipc event 'open-browser-window' to open the child window? (see the slack recipe for how to send an ipc message) + // TODO: Can we change the slack recipe to add a clickHandler for screensharing/video calls? (https://github.com/getferdi/ferdi/issues/1697) const win = new BrowserWindow({ width: 800, height: window.innerHeight, minWidth: 600, webPreferences: { partition: `persist:service-${settings.id}`, + // TODO: Aren't these needed here? + // contextIsolation: false, + // enableRemoteModule: true, }, }); win.loadURL(url); -- cgit v1.2.3-54-g00ecf