From a0555503af19a4c940243fbe777ce939a266fa23 Mon Sep 17 00:00:00 2001
From: Edgars <Edgars+GitHub@gaitenis.id.lv>
Date: Wed, 13 Jul 2022 09:16:50 +0300
Subject: Simplify GitHub badge count detection

GitHub badge count detection was simplified to:

- avoid `if`s;
- improve selector for indirect count element so additional JavaScript
  content checking would not be necessary.
---
 recipes/github/webview.js | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

(limited to 'recipes/github/webview.js')

diff --git a/recipes/github/webview.js b/recipes/github/webview.js
index ab55792..1023975 100644
--- a/recipes/github/webview.js
+++ b/recipes/github/webview.js
@@ -3,19 +3,12 @@ module.exports = Ferdium => {
     const directCountElement = document.querySelector(
       '.filter-list.js-notification-inboxes .count',
     );
-    let directCount = 0;
-    if (directCountElement) {
-      directCount = Ferdium.safeParseInt(directCountElement.textContent);
-    }
-
-    const indirectCountElement = document.querySelector(
-      '[class*="mail-status unread"]',
-    );
-    let indirectCount = 0;
-    if (indirectCountElement && indirectCountElement.textContent.trim().length > 0) {
-      indirectCount = 1;
-    }
-
+    const directCount = directCountElement
+      ? Ferdium.safeParseInt(directCountElement.textContent)
+      : 0;
+    const indirectCount = document.querySelector(
+      '[class*="mail-status unread"]:not([hidden])',
+    ) ? 1 : 0;
     Ferdium.setBadge(directCount, indirectCount);
   };
 
-- 
cgit v1.2.3-70-g09d2