From 9b8f01716774a960073e944823ab727cc867a8f6 Mon Sep 17 00:00:00 2001
From: MCMXC <16797721+mcmxcdev@users.noreply.github.com>
Date: Wed, 26 Jul 2023 06:29:03 -0600
Subject: chore: improve lint setup (#397)

- update eslint config to closely mirror the ones from ferdium-app
- add .eslintignore
- opt in to eslint `reportUnusedDisableDirectives` config option
- remove `trailingComma: all` from `prettier` config which is default in `prettier` v3
- autofix or disable a lot of lint issues throughout codebase
- add `volta` configuration to `package.json` to autoload correct `node` and `pnpm` versions
- upgrade all `eslint` and `prettier` related dependencies to latest
- update lint:fix npm script
- reformat touched files with prettier
- bumped up minor version for all recipes that have changes
- introduced injection of 'service.css' where it was missing in many recipes

---------

Co-authored-by: Vijay A <vraravam@users.noreply.github.com>
---
 recipes/basecamp/webview.js | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

(limited to 'recipes/basecamp/webview.js')

diff --git a/recipes/basecamp/webview.js b/recipes/basecamp/webview.js
index 7d13751..2fe8f7b 100644
--- a/recipes/basecamp/webview.js
+++ b/recipes/basecamp/webview.js
@@ -1,9 +1,9 @@
-const _path = _interopRequireDefault(require('path'));
-
 function _interopRequireDefault(obj) {
   return obj && obj.__esModule ? obj : { default: obj };
 }
 
+const _path = _interopRequireDefault(require('path'));
+
 function show(element) {
   element.style.display = 'inherit';
 }
@@ -16,16 +16,16 @@ module.exports = Ferdium => {
   const modal = document.createElement('div');
 
   const waitFor = (condition, callback) => {
-    if (!condition()) {
-      window.setTimeout(waitFor.bind(null, condition, callback), 100);
-    } else {
+    if (condition()) {
       callback();
+    } else {
+      window.setTimeout(waitFor.bind(null, condition, callback), 100);
     }
   };
   function showModal(text) {
     show(modal);
 
-    let p = modal.querySelector('p');
+    const p = modal.querySelector('p');
 
     if (p) {
       p.textContent = text;
@@ -34,7 +34,7 @@ module.exports = Ferdium => {
 
   function hideModal() {
     hide(modal);
-    let p = modal.querySelector('p');
+    const p = modal.querySelector('p');
 
     if (p) {
       p.textContent = '';
@@ -52,7 +52,7 @@ module.exports = Ferdium => {
   modal.textContent =
     '<div class="modal-content"><span class="close">&times;</span><p></p></div>';
 
-  let close = modal.querySelector('.close');
+  const close = modal.querySelector('.close');
   if (close) {
     close.addEventListener('click', hideModal);
   }
-- 
cgit v1.2.3-54-g00ecf