From 0a3576722cfaafabc28669f2380ab583186e9daa Mon Sep 17 00:00:00 2001 From: Vijay A Date: Mon, 25 Jul 2022 08:38:11 +0530 Subject: eslint needs to be executed at the top-level to actually work --- .github/PULL_REQUEST_TEMPLATE/add_recipe.md | 2 +- .github/workflows/builds.yml | 2 +- docs/integration.md | 2 +- docs/updating.md | 2 +- package.json | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/add_recipe.md b/.github/PULL_REQUEST_TEMPLATE/add_recipe.md index 3756c29..1b2640b 100644 --- a/.github/PULL_REQUEST_TEMPLATE/add_recipe.md +++ b/.github/PULL_REQUEST_TEMPLATE/add_recipe.md @@ -22,7 +22,7 @@ Service ID: [What ID does your recipe use?] - [ ] I am the original creator of this package -- [ ] I have run the `pnpm lint && pnpm reformat-files && pnpm package` and verified that there are no validation errors reported for this package +- [ ] I have run the `pnpm lint:fix && pnpm reformat-files && pnpm package` and verified that there are no validation errors reported for this package - [ ] My recipe has been tested to work inside Ferdium diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml index 9a3533e..0fd768e 100644 --- a/.github/workflows/builds.yml +++ b/.github/workflows/builds.yml @@ -38,6 +38,6 @@ jobs: run: pnpm i - name: Check code style and formatting if: ${{ github.event_name == 'pull_request' }} - run: pnpm lint && pnpm reformat-files + run: pnpm lint:fix && pnpm reformat-files - name: Package recipes run: pnpm package diff --git a/docs/integration.md b/docs/integration.md index fa3949a..1766b9d 100644 --- a/docs/integration.md +++ b/docs/integration.md @@ -53,7 +53,7 @@ This command will automatically create the development recipe in the correct fol 5. (Mandatory) Please run the following step before raising a PR: ```Bash -pnpm i && pnpm lint && pnpm reformat-files && pnpm package +pnpm i && pnpm lint:fix && pnpm reformat-files && pnpm package ``` Fix any issues that are reported. diff --git a/docs/updating.md b/docs/updating.md index aeb2ffe..51505a1 100644 --- a/docs/updating.md +++ b/docs/updating.md @@ -31,6 +31,6 @@ Ferdium uses this version to determine if it should update the local copy of the ## 5. Running the validation checks -This might be the __most important step__ of this guide. You'll need to run the `pnpm lint && pnpm reformat-files && pnpm package` command to ensure that all validation checks are run. +This might be the __most important step__ of this guide. You'll need to run the `pnpm lint:fix && pnpm reformat-files && pnpm package` command to ensure that all validation checks are run. ## 6. Commit your changes and create a PR to diff --git a/package.json b/package.json index f243f82..dce39ce 100644 --- a/package.json +++ b/package.json @@ -12,8 +12,8 @@ "prepare": "pnpm dlx husky install", "package": "node scripts/package.js", "create": "node scripts/create.js", - "lint": "eslint \"{recipes,scripts}/**/*.{js,jsx,ts,tsx}\" --quiet", - "lint:fix": "npm run lint -- --fix", + "lint": "pnpx eslint \"{recipes,scripts}/**/*.{js,jsx,ts,tsx}\"", + "lint:fix": "pnpx eslint --fix \"{recipes,scripts}/**/*.{js,jsx,ts,tsx}\"", "reformat-files": "prettier --ignore-path .eslintignore --write --require-pragma \"**/*.{js,json,scss}\"", "contributors": "all-contributors" }, -- cgit v1.2.3-70-g09d2