Cleanup all recipes (#605)

* Removed legacy properties that are no longer used:
  'author'
  'customURL'
  'description'
  'hostedOnly'
  'main'
  'openDevTools'
  'popup'
  'repository'
  'serviceName'
  'webviewOptions'
  'wording'

- Removed entries for if they were the defaults:
  'hasCustomUrl'
  'hasDirectMessages'
  'hasIndirectMessages'
  'hasNotificationSound'
  'hasTeamId'
  'message'

Fixed incorrect 'urlInputSuffix' type.

Added validations for ensuring the above do not creep back in.

2 files changed, 28 insertions, 5 deletions

diff --git a/scripts/package.js b/scripts/package.js
index b7d6a7f..8410247 100644
--- a/scripts/package.js
+++ b/scripts/package.js
@@ -112,6 +112,33 @@ const compress = (src, dest) => new Promise((resolve, reject) => {
       configErrors.push("The recipe's package.json contains no 'config' object. This field should contain a configuration for your service.");
     }
 
+    const topLevelKeys = Object.keys(config);
+    topLevelKeys.forEach(key => {
+      if (typeof(config[key]) === 'string' && config[key] === '') {
+        configErrors.push(`The recipe's package.json contains empty value for key: ${key}`);
+      }
+    });
+
+    const knownTopLevelKeys = ['id', 'name', 'version', 'license', 'repository', 'config'];
+    const unrecognizedKeys = topLevelKeys.filter(x => !knownTopLevelKeys.includes(x));
+    if (unrecognizedKeys.length > 0) {
+      configErrors.push(`The recipe's package.json contains the following keys that are not recognized: ${unrecognizedKeys}`);
+    }
+    if (config.config && typeof config.config === "object") {
+      const configKeys = Object.keys(config.config);
+      const knownConfigKeys = ['serviceURL', 'hasTeamId', 'urlInputPrefix', 'urlInputSuffix', 'hasHostedOption', 'hasCustomUrl', 'hasNotificationSound', 'hasDirectMessages', 'hasIndirectMessages', 'message', 'disablewebsecurity'];
+      const unrecognizedConfigKeys = configKeys.filter(x => !knownConfigKeys.includes(x));
+      if (unrecognizedConfigKeys.length > 0) {
+        configErrors.push(`The recipe's package.json contains the following keys that are not recognized: ${unrecognizedConfigKeys}`);
+      }
+
+      configKeys.forEach(key => {
+        if (typeof(config.config[key]) === 'string' && config.config[key] === '') {
+          configErrors.push(`The recipe's package.json contains empty value for key: ${key}`);
+        }
+      });
+    }
+
     if (isGitRepo) {
       const relativeRepoSrc = path.relative(repoRoot, recipeSrc);
 
@@ -158,7 +185,6 @@ const compress = (src, dest) => new Promise((resolve, reject) => {
     // Add recipe to all.json
     const isFeatured = featuredRecipes.includes(config.id);
     const packageInfo = {
-      "author": config.author || '',
       "featured": isFeatured,
       "id": config.id,
       "name": config.name,
diff --git a/scripts/sample_recipe/package.json b/scripts/sample_recipe/package.json
index af522db..6481f95 100644
--- a/scripts/sample_recipe/package.json
+++ b/scripts/sample_recipe/package.json
@@ -1,10 +1,7 @@
 {
   "id": "SERVICE",
   "name": "SNAME",
-  "version": "1.0.0",
-  "description": "SERVICE",
-  "main": "index.js",
-  "author": "Ferdi <hello@getferdi.com>",
+  "version": "1.0.1",
   "license": "MIT",
   "config": {
     "serviceURL": "https://SERVICE.com"