fix: updated 'skype' and 'discord' to properly relinquish 'win' object for image overlay

1 files changed, 7 insertions, 3 deletions

diff --git a/recipes/skype/webview.js b/recipes/skype/webview.js
index 18b63a5..d9775dd 100644
--- a/recipes/skype/webview.js
+++ b/recipes/skype/webview.js
@@ -30,6 +30,7 @@ module.exports = (Ferdi, settings) => {
   Ferdi.injectCSS(_path.default.join(__dirname, 'service.css'));
   Ferdi.injectJSUnsafe(_path.default.join(__dirname, 'webview-unsafe.js'));
 
+  // TODO: This whole block is duplicated between the 'discord' and 'skype' recipes - reuse
   document.addEventListener('click', event => {
     const link = event.target.closest('a[href^="http"]');
     const button = event.target.closest('button[title^="http"]');
@@ -42,18 +43,21 @@ module.exports = (Ferdi, settings) => {
         event.stopPropagation();
         // TODO: Can we send an ipc event 'open-browser-window' to open the child window? (see the slack recipe for how to send an ipc message)
         // TODO: Can we change the slack recipe to add a clickHandler for screensharing/video calls? (https://github.com/getferdi/ferdi/issues/1697)
-        const win = new Ferdi.BrowserWindow({
+        let win = new Ferdi.BrowserWindow({
           width: 800,
           height: window.innerHeight,
           minWidth: 600,
           webPreferences: {
-            partition: `persist:service-${settings.id}`,
+            partition: `persist:service-${settings.id}`
             // TODO: Aren't these needed here?
             // contextIsolation: false,
             // enableRemoteModule: true,
-          },
+          }
         });
         win.loadURL(url);
+        win.on('closed', () => {
+          win = null;
+        });
       }
     }
   }, true);