diff options
author | Vijay A <avijayr@protonmail.com> | 2021-08-13 09:24:12 +0530 |
---|---|---|
committer | Vijay A <avijayr@protonmail.com> | 2021-08-13 09:24:12 +0530 |
commit | c7ba960cfdfbd3dc17904d10cbc4da1d3998348c (patch) | |
tree | 27f90e708bb35f61bf2a5f43318813180efcbca1 | |
parent | Fixed icon size for gChat (diff) | |
download | ferdium-recipes-c7ba960cfdfbd3dc17904d10cbc4da1d3998348c.tar.gz ferdium-recipes-c7ba960cfdfbd3dc17904d10cbc4da1d3998348c.tar.zst ferdium-recipes-c7ba960cfdfbd3dc17904d10cbc4da1d3998348c.zip |
Added TODOs related to opening child window for screensharing/video calls.
-rw-r--r-- | recipes/skype/webview.js | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/recipes/skype/webview.js b/recipes/skype/webview.js index f8b4d7b..c20726c 100644 --- a/recipes/skype/webview.js +++ b/recipes/skype/webview.js | |||
@@ -35,12 +35,17 @@ module.exports = (Franz, settings) => { | |||
35 | if (url.includes('views/imgpsh_fullsize_anim')) { | 35 | if (url.includes('views/imgpsh_fullsize_anim')) { |
36 | event.preventDefault(); | 36 | event.preventDefault(); |
37 | event.stopPropagation(); | 37 | event.stopPropagation(); |
38 | // TODO: Can we send an ipc event 'open-browser-window' to open the child window? (see the slack recipe for how to send an ipc message) | ||
39 | // TODO: Can we change the slack recipe to add a clickHandler for screensharing/video calls? (https://github.com/getferdi/ferdi/issues/1697) | ||
38 | const win = new BrowserWindow({ | 40 | const win = new BrowserWindow({ |
39 | width: 800, | 41 | width: 800, |
40 | height: window.innerHeight, | 42 | height: window.innerHeight, |
41 | minWidth: 600, | 43 | minWidth: 600, |
42 | webPreferences: { | 44 | webPreferences: { |
43 | partition: `persist:service-${settings.id}`, | 45 | partition: `persist:service-${settings.id}`, |
46 | // TODO: Aren't these needed here? | ||
47 | // contextIsolation: false, | ||
48 | // enableRemoteModule: true, | ||
44 | }, | 49 | }, |
45 | }); | 50 | }); |
46 | win.loadURL(url); | 51 | win.loadURL(url); |