aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLibravatar Rui Gonçalves <rui@fb.com>2020-07-20 13:23:23 +0100
committerLibravatar Rui Gonçalves <rui@fb.com>2020-07-20 13:23:23 +0100
commit7b6f329b85912afab5d8576de26ed57f25230131 (patch)
tree5c06cea0fb54a934a22d94953be9707e9cfc226c
parentMerge pull request #217 from yann-soubeyrand/patch-1 (diff)
downloadferdium-recipes-7b6f329b85912afab5d8576de26ed57f25230131.tar.gz
ferdium-recipes-7b6f329b85912afab5d8576de26ed57f25230131.tar.zst
ferdium-recipes-7b6f329b85912afab5d8576de26ed57f25230131.zip
Add support for empty unread badges
Empty unread badges show up when people manually "Mark as Unread" chat threads. Currently, this stops notifications from appearing as counts become NaN. With this PR they will stop being counted (since we don't have message counts in those cases and it's not really a notification I think this is probably the best behavior, but I'm ok with defaulting to 1).
-rw-r--r--all.json2
-rw-r--r--archives/whatsapp.tar.gzbin183549 -> 183548 bytes
-rw-r--r--uncompressed/whatsapp/package.json2
-rw-r--r--uncompressed/whatsapp/webview.js4
4 files changed, 4 insertions, 4 deletions
diff --git a/all.json b/all.json
index 3ab1923..314f7a8 100644
--- a/all.json
+++ b/all.json
@@ -1126,7 +1126,7 @@
1126 "featured": true, 1126 "featured": true,
1127 "id": "whatsapp", 1127 "id": "whatsapp",
1128 "name": "WhatsApp", 1128 "name": "WhatsApp",
1129 "version": "2.0.6", 1129 "version": "2.0.7",
1130 "icons": { 1130 "icons": {
1131 "png": "https://cdn.jsdelivr.net/gh/getferdi/recipes/uncompressed/whatsapp/icon.png", 1131 "png": "https://cdn.jsdelivr.net/gh/getferdi/recipes/uncompressed/whatsapp/icon.png",
1132 "svg": "https://cdn.jsdelivr.net/gh/getferdi/recipes/uncompressed/whatsapp/icon.svg" 1132 "svg": "https://cdn.jsdelivr.net/gh/getferdi/recipes/uncompressed/whatsapp/icon.svg"
diff --git a/archives/whatsapp.tar.gz b/archives/whatsapp.tar.gz
index dd48a42..4bb91a0 100644
--- a/archives/whatsapp.tar.gz
+++ b/archives/whatsapp.tar.gz
Binary files differ
diff --git a/uncompressed/whatsapp/package.json b/uncompressed/whatsapp/package.json
index 4dc3f3b..c4c60ce 100644
--- a/uncompressed/whatsapp/package.json
+++ b/uncompressed/whatsapp/package.json
@@ -1,7 +1,7 @@
1{ 1{
2 "id": "whatsapp", 2 "id": "whatsapp",
3 "name": "WhatsApp", 3 "name": "WhatsApp",
4 "version": "2.0.6", 4 "version": "2.0.7",
5 "description": "WhatsApp", 5 "description": "WhatsApp",
6 "main": "index.js", 6 "main": "index.js",
7 "author": "Stefan Malzner <stefan@adlk.io>", 7 "author": "Stefan Malzner <stefan@adlk.io>",
diff --git a/uncompressed/whatsapp/webview.js b/uncompressed/whatsapp/webview.js
index 23838ac..263c543 100644
--- a/uncompressed/whatsapp/webview.js
+++ b/uncompressed/whatsapp/webview.js
@@ -33,7 +33,7 @@ module.exports = Franz => {
33 var indirectCount = 0; 33 var indirectCount = 0;
34 34
35 for (var i = 0; i < elements.length; i += 1) { 35 for (var i = 0; i < elements.length; i += 1) {
36 var countValue = parseInt(elements[i].textContent, 10); 36 var countValue = parseInt(elements[i].textContent || '0', 10);
37 37
38 if (elements[i].parentNode.previousElementSibling === null || elements[i].parentNode.previousElementSibling.querySelectorAll("[data-icon=muted]").length === 0) { 38 if (elements[i].parentNode.previousElementSibling === null || elements[i].parentNode.previousElementSibling.querySelectorAll("[data-icon=muted]").length === 0) {
39 count += countValue; 39 count += countValue;
@@ -48,4 +48,4 @@ module.exports = Franz => {
48 48
49 Franz.injectCSS(path.join(__dirname, 'service.css')); 49 Franz.injectCSS(path.join(__dirname, 'service.css'));
50 Franz.loop(getMessages); 50 Franz.loop(getMessages);
51}; \ No newline at end of file 51};