From 8c131073730ec684145c2cc8ee8d6b39bbe9278d Mon Sep 17 00:00:00 2001 From: MCMXC <16797721+mcmxcdev@users.noreply.github.com> Date: Sun, 23 Jul 2023 20:08:52 -0600 Subject: chore: improve lint setup - update eslint config - merged eslint rules for JS and TS to avoid duplicates - extended stricter lint ruleset from typescript-eslint - corrected wrong setup for certain eslint rulesets - opt in to reportUnusedDisableDirectives config option - fix or disable a lot of lint issues throughout codebase - remove trailingComma: all from prettier config which is default in prettier v3 - add volta configuration to package.json to autoload correct node and pnpm versions - upgrade all eslint and prettier related dependencies to latest - remove config options from settings.json which are default anyways - remove config options from settings.json which are outdated/unknown - set up prettier as default formatter in settings.json --- src/stores/SettingsStore.ts | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) (limited to 'src/stores/SettingsStore.ts') diff --git a/src/stores/SettingsStore.ts b/src/stores/SettingsStore.ts index 5ca499160..90cd82690 100644 --- a/src/stores/SettingsStore.ts +++ b/src/stores/SettingsStore.ts @@ -70,14 +70,17 @@ export default class SettingsStore extends TypedStore { this.all.app.lockingFeatureEnabled && this.all.app.inactivityLock !== 0 ) { - inactivityTimer = setTimeout(() => { - this.actions.settings.update({ - type: 'app', - data: { - locked: true, - }, - }); - }, this.all.app.inactivityLock * 1000 * 60); + inactivityTimer = setTimeout( + () => { + this.actions.settings.update({ + type: 'app', + data: { + locked: true, + }, + }); + }, + this.all.app.inactivityLock * 1000 * 60, + ); } }); getCurrentWindow().on('focus', () => { @@ -176,6 +179,7 @@ export default class SettingsStore extends TypedStore { const appSettings = this.all[type]; if (Object.hasOwnProperty.call(appSettings, key)) { + // eslint-disable-next-line @typescript-eslint/no-dynamic-delete delete appSettings[key]; this.actions.settings.update({ @@ -185,6 +189,7 @@ export default class SettingsStore extends TypedStore { } } + // eslint-disable-next-line @typescript-eslint/ban-types _ensureMigrationAndMarkDone(migrationName: string, callback: Function): void { if (!this.all.migration[migrationName]) { callback(); -- cgit v1.2.3-70-g09d2