From 8c131073730ec684145c2cc8ee8d6b39bbe9278d Mon Sep 17 00:00:00 2001 From: MCMXC <16797721+mcmxcdev@users.noreply.github.com> Date: Sun, 23 Jul 2023 20:08:52 -0600 Subject: chore: improve lint setup - update eslint config - merged eslint rules for JS and TS to avoid duplicates - extended stricter lint ruleset from typescript-eslint - corrected wrong setup for certain eslint rulesets - opt in to reportUnusedDisableDirectives config option - fix or disable a lot of lint issues throughout codebase - remove trailingComma: all from prettier config which is default in prettier v3 - add volta configuration to package.json to autoload correct node and pnpm versions - upgrade all eslint and prettier related dependencies to latest - remove config options from settings.json which are default anyways - remove config options from settings.json which are outdated/unknown - set up prettier as default formatter in settings.json --- src/stores/AppStore.ts | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/stores/AppStore.ts') diff --git a/src/stores/AppStore.ts b/src/stores/AppStore.ts index 82591a2a4..412c52ecf 100644 --- a/src/stores/AppStore.ts +++ b/src/stores/AppStore.ts @@ -351,6 +351,7 @@ export default class AppStore extends TypedStore { // TODO: is there a simple way to use blobs for notifications without storing them on disk? if (options.icon?.startsWith('blob:')) { + // eslint-disable-next-line no-param-reassign delete options.icon; } @@ -493,6 +494,7 @@ export default class AppStore extends TypedStore { allOrphanedServiceIds.map(id => removeServicePartitionDirectory(id)), ); } catch (error) { + // eslint-disable-next-line no-console console.log('Error while deleting service partition directory -', error); } await Promise.all( -- cgit v1.2.3-54-g00ecf