From c49723056acec489765acb54bae3889ac07f25af Mon Sep 17 00:00:00 2001 From: MCMXC <16797721+mcmxcdev@users.noreply.github.com> Date: Thu, 18 Apr 2024 08:18:36 -0600 Subject: refactor: bring down eslint warnings to zero (#1714) - install `@eslint-react/eslint-plugin` dependency - configure `@eslint-react/eslint-plugin` in eslint config - modernize `lint` command in `package.json` - disable or fix various reported lint issues - fix `div` being nested in `p` for settings - replace deprecated `event.keyCode` with `event.key` - update isEscKeyPress method and unit tests which used deprecated `event.keyCode` - allow `eslint` v8 as peer dependency for `@eslint-react/eslint-plugin` --- src/internal-server/app/Controllers/Http/ImageController.js | 1 + src/internal-server/start/migrate.js | 1 + src/internal-server/test.ts | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) (limited to 'src/internal-server') diff --git a/src/internal-server/app/Controllers/Http/ImageController.js b/src/internal-server/app/Controllers/Http/ImageController.js index 3ce6fb22d..930eca693 100644 --- a/src/internal-server/app/Controllers/Http/ImageController.js +++ b/src/internal-server/app/Controllers/Http/ImageController.js @@ -20,6 +20,7 @@ class ImageController { try { await fs.access(iconPath); } catch (error) { + // eslint-disable-next-line no-console console.log(error); // File not available. return response.status(404).send({ diff --git a/src/internal-server/start/migrate.js b/src/internal-server/start/migrate.js index 67533ed9e..bbe12f5ba 100644 --- a/src/internal-server/start/migrate.js +++ b/src/internal-server/start/migrate.js @@ -8,6 +8,7 @@ const Database = use('Database'); const User = use('App/Models/User'); const migrateLog = text => { + // eslint-disable-next-line no-console console.log('\u001B[36m%s\u001B[0m', 'Ferdium Migration:', '\u001B[0m', text); }; diff --git a/src/internal-server/test.ts b/src/internal-server/test.ts index c163656fb..991218942 100644 --- a/src/internal-server/test.ts +++ b/src/internal-server/test.ts @@ -6,5 +6,5 @@ const dummyUserFolder = join(__dirname, 'user_data'); ensureDirSync(dummyUserFolder); -// eslint-disable-next-line unicorn/prefer-top-level-await +// eslint-disable-next-line unicorn/prefer-top-level-await, no-console server(dummyUserFolder, 46_568, 'test').catch(console.log); -- cgit v1.2.3-70-g09d2