From 99ca310c73024b51fed1f3077375eed7827f2c20 Mon Sep 17 00:00:00 2001 From: Vijay A Date: Sun, 28 May 2023 13:48:21 +0530 Subject: Fix issues reported by sonarqube linter --- src/features/workspaces/components/WorkspaceDrawerItem.tsx | 9 +++++---- src/features/workspaces/components/WorkspaceItem.tsx | 2 +- .../workspaces/components/WorkspaceSwitchingIndicator.tsx | 9 +++++---- src/features/workspaces/components/WorkspacesDashboard.tsx | 2 +- src/features/workspaces/store.ts | 4 ++-- 5 files changed, 14 insertions(+), 12 deletions(-) (limited to 'src/features/workspaces') diff --git a/src/features/workspaces/components/WorkspaceDrawerItem.tsx b/src/features/workspaces/components/WorkspaceDrawerItem.tsx index 0ad56d1ae..74ca2797d 100644 --- a/src/features/workspaces/components/WorkspaceDrawerItem.tsx +++ b/src/features/workspaces/components/WorkspaceDrawerItem.tsx @@ -19,10 +19,11 @@ const messages = defineMessages({ }, }); -const itemTransition = - window && window.matchMedia('(prefers-reduced-motion: no-preference)') - ? 'background-color 300ms ease-out' - : 'none'; +const itemTransition = window?.matchMedia( + '(prefers-reduced-motion: no-preference)', +) + ? 'background-color 300ms ease-out' + : 'none'; const styles = theme => ({ item: { diff --git a/src/features/workspaces/components/WorkspaceItem.tsx b/src/features/workspaces/components/WorkspaceItem.tsx index b097a8298..6c4dd649b 100644 --- a/src/features/workspaces/components/WorkspaceItem.tsx +++ b/src/features/workspaces/components/WorkspaceItem.tsx @@ -1,4 +1,4 @@ -/* eslint-disable jsx-a11y/no-noninteractive-element-interactions */ // TODO - [TS DEBT] Need to check and remove it +/* eslint-disable jsx-a11y/no-noninteractive-element-interactions */ import { Component, ReactElement } from 'react'; import { observer } from 'mobx-react'; import withStyles, { WithStylesProps } from 'react-jss'; diff --git a/src/features/workspaces/components/WorkspaceSwitchingIndicator.tsx b/src/features/workspaces/components/WorkspaceSwitchingIndicator.tsx index c9af22c96..e1cc0f785 100644 --- a/src/features/workspaces/components/WorkspaceSwitchingIndicator.tsx +++ b/src/features/workspaces/components/WorkspaceSwitchingIndicator.tsx @@ -14,10 +14,11 @@ const messages = defineMessages({ }, }); -const wrapperTransition = - window && window.matchMedia('(prefers-reduced-motion: no-preference)') - ? 'width 0.5s ease' - : 'none'; +const wrapperTransition = window?.matchMedia( + '(prefers-reduced-motion: no-preference)', +) + ? 'width 0.5s ease' + : 'none'; const styles = theme => ({ wrapper: { diff --git a/src/features/workspaces/components/WorkspacesDashboard.tsx b/src/features/workspaces/components/WorkspacesDashboard.tsx index 06738b38c..c5f8909c1 100644 --- a/src/features/workspaces/components/WorkspacesDashboard.tsx +++ b/src/features/workspaces/components/WorkspacesDashboard.tsx @@ -147,7 +147,7 @@ class WorkspacesDashboard extends Component { icon="alert" type="danger" ctaLabel={intl.formatMessage(messages.tryReloadWorkspaces)} - // ctaLoading={getUserWorkspacesRequest.isExecuting} // TODO - [TECH DEBT][PROP NOT USED IN COMPONENT] need to check and update + // ctaLoading={getUserWorkspacesRequest.isExecuting} // TODO: [TECH DEBT][PROP NOT USED IN COMPONENT] need to check and update ctaOnClick={getUserWorkspacesRequest.retry} > {intl.formatMessage(messages.workspacesRequestFailed)} diff --git a/src/features/workspaces/store.ts b/src/features/workspaces/store.ts index d63feb1f8..53e3b62ed 100644 --- a/src/features/workspaces/store.ts +++ b/src/features/workspaces/store.ts @@ -28,7 +28,7 @@ export default class WorkspacesStore extends FeatureStore { @observable nextWorkspace: Workspace | undefined; - @observable workspaceBeingEdited: any = null; // TODO - [TS DEBT] fix type later + @observable workspaceBeingEdited: any = null; // TODO: [TS DEBT] fix type later @observable isSwitchingWorkspace = false; @@ -36,7 +36,7 @@ export default class WorkspacesStore extends FeatureStore { @observable isSettingsRouteActive = false; - stores: any; // TODO - [TS DEBT] fix type later + stores: any; // TODO: [TS DEBT] fix type later actions: Actions | undefined; -- cgit v1.2.3-54-g00ecf