From c49723056acec489765acb54bae3889ac07f25af Mon Sep 17 00:00:00 2001 From: MCMXC <16797721+mcmxcdev@users.noreply.github.com> Date: Thu, 18 Apr 2024 08:18:36 -0600 Subject: refactor: bring down eslint warnings to zero (#1714) - install `@eslint-react/eslint-plugin` dependency - configure `@eslint-react/eslint-plugin` in eslint config - modernize `lint` command in `package.json` - disable or fix various reported lint issues - fix `div` being nested in `p` for settings - replace deprecated `event.keyCode` with `event.key` - update isEscKeyPress method and unit tests which used deprecated `event.keyCode` - allow `eslint` v8 as peer dependency for `@eslint-react/eslint-plugin` --- src/electron/ipc-api/autoUpdate.ts | 1 + src/electron/ipc-api/index.ts | 1 + src/electron/macOSPermissions.ts | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) (limited to 'src/electron') diff --git a/src/electron/ipc-api/autoUpdate.ts b/src/electron/ipc-api/autoUpdate.ts index 775daf602..44e2a1b19 100644 --- a/src/electron/ipc-api/autoUpdate.ts +++ b/src/electron/ipc-api/autoUpdate.ts @@ -1,5 +1,6 @@ import { BrowserWindow, ipcMain } from 'electron'; import { autoUpdater } from 'electron-updater'; +// eslint-disable-next-line import/no-cycle import { appEvents } from '../..'; const debug = require('../../preload-safe-debug')('Ferdium:ipcApi:autoUpdate'); diff --git a/src/electron/ipc-api/index.ts b/src/electron/ipc-api/index.ts index 48c6d142c..83cc5eae2 100644 --- a/src/electron/ipc-api/index.ts +++ b/src/electron/ipc-api/index.ts @@ -1,6 +1,7 @@ import type { BrowserWindow } from 'electron'; import type TrayIcon from '../../lib/Tray'; import appIndicator from './appIndicator'; +// eslint-disable-next-line import/no-cycle import autoUpdate from './autoUpdate'; import dnd from './dnd'; import download from './download'; diff --git a/src/electron/macOSPermissions.ts b/src/electron/macOSPermissions.ts index 90f0f4028..a3bbbbe19 100644 --- a/src/electron/macOSPermissions.ts +++ b/src/electron/macOSPermissions.ts @@ -2,7 +2,7 @@ import { dirname } from 'node:path'; import { type BrowserWindow, dialog, systemPreferences } from 'electron'; import { mkdirSync, pathExistsSync, writeFileSync } from 'fs-extra'; import macosVersion from 'macos-version'; -// eslint-disable-next-line @typescript-eslint/ban-ts-comment, @typescript-eslint/prefer-ts-expect-error +// eslint-disable-next-line @typescript-eslint/prefer-ts-expect-error // @ts-ignore import { askForScreenCaptureAccess } from 'node-mac-permissions'; import { userDataPath } from '../environment-remote'; -- cgit v1.2.3-70-g09d2