From 8c131073730ec684145c2cc8ee8d6b39bbe9278d Mon Sep 17 00:00:00 2001
From: MCMXC <16797721+mcmxcdev@users.noreply.github.com>
Date: Sun, 23 Jul 2023 20:08:52 -0600
Subject: chore: improve lint setup

- update eslint config
- merged eslint rules for JS and TS to avoid duplicates
- extended stricter lint ruleset from typescript-eslint
- corrected wrong setup for certain eslint rulesets
- opt in to reportUnusedDisableDirectives config option
- fix or disable a lot of lint issues throughout codebase
- remove trailingComma: all from prettier config which is default in prettier v3
- add volta configuration to package.json to autoload correct node and pnpm versions
- upgrade all eslint and prettier related dependencies to latest
- remove config options from settings.json which are default anyways
- remove config options from settings.json which are outdated/unknown
- set up prettier as default formatter in settings.json
---
 src/containers/auth/WelcomeScreen.tsx          | 4 ----
 src/containers/layout/AppLayoutContainer.tsx   | 1 -
 src/containers/settings/EditSettingsScreen.tsx | 2 --
 src/containers/settings/EditUserScreen.tsx     | 2 --
 4 files changed, 9 deletions(-)

(limited to 'src/containers')

diff --git a/src/containers/auth/WelcomeScreen.tsx b/src/containers/auth/WelcomeScreen.tsx
index 561eef236..1f3f50e4a 100644
--- a/src/containers/auth/WelcomeScreen.tsx
+++ b/src/containers/auth/WelcomeScreen.tsx
@@ -8,10 +8,6 @@ interface IProps extends Partial<StoresProps> {}
 @inject('stores', 'actions')
 @observer
 class WelcomeScreen extends Component<IProps> {
-  constructor(props: IProps) {
-    super(props);
-  }
-
   render(): ReactElement {
     const { user, recipePreviews } = this.props.stores!;
 
diff --git a/src/containers/layout/AppLayoutContainer.tsx b/src/containers/layout/AppLayoutContainer.tsx
index 1929492ff..e30c0e067 100644
--- a/src/containers/layout/AppLayoutContainer.tsx
+++ b/src/containers/layout/AppLayoutContainer.tsx
@@ -74,7 +74,6 @@ class AppLayoutContainer extends Component<IProps> {
 
     const workspacesDrawer = (
       <WorkspaceDrawer
-        // eslint-disable-next-line no-confusing-arrow
         getServicesForWorkspace={workspace =>
           workspace
             ? workspaceStore.getWorkspaceServices(workspace).map(s => s.name)
diff --git a/src/containers/settings/EditSettingsScreen.tsx b/src/containers/settings/EditSettingsScreen.tsx
index 0f3359bfc..7cdff7fde 100644
--- a/src/containers/settings/EditSettingsScreen.tsx
+++ b/src/containers/settings/EditSettingsScreen.tsx
@@ -1172,8 +1172,6 @@ class EditSettingsScreen extends Component<EditSettingsScreenProps> {
       };
     }
 
-    // @ts-ignore: Remove this ignore once mobx-react-form v4 with typescript
-    // support has been released.
     return new Form(config);
   }
 
diff --git a/src/containers/settings/EditUserScreen.tsx b/src/containers/settings/EditUserScreen.tsx
index 0d6c47da5..10c308524 100644
--- a/src/containers/settings/EditUserScreen.tsx
+++ b/src/containers/settings/EditUserScreen.tsx
@@ -126,8 +126,6 @@ class EditUserScreen extends Component<EditUserScreenProps> {
       },
     };
 
-    // @ts-ignore: Remove this ignore once mobx-react-form v4 with typescript
-    // support has been released.
     return new Form(config);
   }
 
-- 
cgit v1.2.3-54-g00ecf