From 97d51a7763b14c92ee71ff9a012311dd9498d803 Mon Sep 17 00:00:00 2001 From: Vijay Raghavan Aravamudhan Date: Sun, 8 Aug 2021 00:01:37 +0000 Subject: refactor: path-references refactoring and using 'import' instead of 'require' (#1752) * refactor references to 'userData' and 'appData' directories to move hardcoding into single location * convert to es6 for lower memory usage as per https://codesource.io/the-difference-between-import-and-require-in-javascript/ --- src/containers/settings/RecipesScreen.js | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'src/containers/settings') diff --git a/src/containers/settings/RecipesScreen.js b/src/containers/settings/RecipesScreen.js index 93503fb0e..ff3c688fa 100644 --- a/src/containers/settings/RecipesScreen.js +++ b/src/containers/settings/RecipesScreen.js @@ -1,11 +1,9 @@ import { shell } from 'electron'; -import { app } from '@electron/remote'; -import fs from 'fs-extra'; +import { ensureDirSync, readJsonSync } from 'fs-extra'; import React, { Component } from 'react'; import PropTypes from 'prop-types'; import { autorun } from 'mobx'; import { inject, observer } from 'mobx-react'; -import path from 'path'; import RecipePreviewsStore from '../../stores/RecipePreviewsStore'; import RecipeStore from '../../stores/RecipesStore'; @@ -15,7 +13,7 @@ import UserStore from '../../stores/UserStore'; import RecipesDashboard from '../../components/settings/recipes/RecipesDashboard'; import ErrorBoundary from '../../components/util/ErrorBoundary'; import { CUSTOM_WEBSITE_RECIPE_ID, FRANZ_DEV_DOCS } from '../../config'; -import { RECIPES_PATH } from '../../environment'; +import { asarRecipesPath, userDataRecipesPath } from '../../environment'; import { communityRecipesStore } from '../../features/communityRecipes'; import RecipePreview from '../../models/RecipePreview'; import AppStore from '../../stores/AppStore'; @@ -45,7 +43,7 @@ export default @inject('stores', 'actions') @observer class RecipesScreen extend constructor(props) { super(props); - this.customRecipes = fs.readJsonSync(path.join(RECIPES_PATH, 'all.json')); + this.customRecipes = readJsonSync(asarRecipesPath('all.json')); } componentDidMount() { @@ -140,7 +138,7 @@ export default @inject('stores', 'actions') @observer class RecipesScreen extend || recipes.installRecipeRequest.isExecuting || recipePreviews.searchRecipePreviewsRequest.isExecuting; - const recipeDirectory = path.join(app.getPath('userData'), 'recipes', 'dev'); + const recipeDirectory = userDataRecipesPath('dev'); return ( @@ -157,7 +155,7 @@ export default @inject('stores', 'actions') @observer class RecipesScreen extend recipeFilter={filter} recipeDirectory={recipeDirectory} openRecipeDirectory={async () => { - await fs.ensureDir(recipeDirectory); + ensureDirSync(recipeDirectory); shell.openExternal(`file://${recipeDirectory}`); }} openDevDocs={() => { -- cgit v1.2.3-70-g09d2