From 95df3522a15631abc51a4295cae0ea401a8d4e1e Mon Sep 17 00:00:00 2001 From: Markus Hatvan Date: Tue, 14 Sep 2021 19:58:52 +0200 Subject: feat: add eslint-plugin-unicorn (#1936) --- src/containers/settings/AccountScreen.js | 14 ++++++-------- src/containers/settings/SettingsWindow.js | 4 ++-- 2 files changed, 8 insertions(+), 10 deletions(-) (limited to 'src/containers/settings') diff --git a/src/containers/settings/AccountScreen.js b/src/containers/settings/AccountScreen.js index cc3929656..0f9457fd0 100644 --- a/src/containers/settings/AccountScreen.js +++ b/src/containers/settings/AccountScreen.js @@ -32,14 +32,12 @@ class AccountScreen extends Component { const api = stores.settings.all.app.server; - let url; - if (api === LIVE_FRANZ_API) { - url = stores.user.getAuthURL( - `${WEBSITE}${route}?utm_source=app&utm_medium=account_dashboard`, - ); - } else { - url = `${api}${route}`; - } + const url = + api === LIVE_FRANZ_API + ? stores.user.getAuthURL( + `${WEBSITE}${route}?utm_source=app&utm_medium=account_dashboard`, + ) + : `${api}${route}`; actions.app.openExternalUrl({ url }); } diff --git a/src/containers/settings/SettingsWindow.js b/src/containers/settings/SettingsWindow.js index 58e73f2f3..e03c4c1d2 100644 --- a/src/containers/settings/SettingsWindow.js +++ b/src/containers/settings/SettingsWindow.js @@ -19,11 +19,11 @@ class SettingsContainer extends Component { el = document.createElement('div'); componentDidMount() { - this.portalRoot.appendChild(this.el); + this.portalRoot.append(this.el); } componentWillUnmount() { - this.portalRoot.removeChild(this.el); + this.el.remove(); } render() { -- cgit v1.2.3-70-g09d2