From 8c131073730ec684145c2cc8ee8d6b39bbe9278d Mon Sep 17 00:00:00 2001
From: MCMXC <16797721+mcmxcdev@users.noreply.github.com>
Date: Sun, 23 Jul 2023 20:08:52 -0600
Subject: chore: improve lint setup

- update eslint config
- merged eslint rules for JS and TS to avoid duplicates
- extended stricter lint ruleset from typescript-eslint
- corrected wrong setup for certain eslint rulesets
- opt in to reportUnusedDisableDirectives config option
- fix or disable a lot of lint issues throughout codebase
- remove trailingComma: all from prettier config which is default in prettier v3
- add volta configuration to package.json to autoload correct node and pnpm versions
- upgrade all eslint and prettier related dependencies to latest
- remove config options from settings.json which are default anyways
- remove config options from settings.json which are outdated/unknown
- set up prettier as default formatter in settings.json
---
 src/components/services/tabs/TabBarSortableList.tsx | 2 +-
 src/components/services/tabs/TabItem.tsx            | 8 ++++----
 src/components/services/tabs/Tabbar.tsx             | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

(limited to 'src/components/services/tabs')

diff --git a/src/components/services/tabs/TabBarSortableList.tsx b/src/components/services/tabs/TabBarSortableList.tsx
index 5f711c30d..a30587470 100644
--- a/src/components/services/tabs/TabBarSortableList.tsx
+++ b/src/components/services/tabs/TabBarSortableList.tsx
@@ -51,7 +51,7 @@ class TabBarSortableList extends Component<IProps> {
         {services.map((service, index) => (
           <TabItem
             key={service.id}
-            // @ts-ignore
+            // @ts-expect-error Fix me
             clickHandler={() => setActive({ serviceId: service.id })}
             service={service}
             index={index}
diff --git a/src/components/services/tabs/TabItem.tsx b/src/components/services/tabs/TabItem.tsx
index c25af4427..287dedfcb 100644
--- a/src/components/services/tabs/TabItem.tsx
+++ b/src/components/services/tabs/TabItem.tsx
@@ -234,7 +234,7 @@ class TabItem extends Component<IProps, IState> {
     } = this.props;
     const { intl } = this.props;
 
-    const menuTemplate: Array<MenuItemConstructorOptions> = [
+    const menuTemplate: MenuItemConstructorOptions[] = [
       {
         label: service.name || service.recipe.name,
         enabled: false,
@@ -295,7 +295,7 @@ class TabItem extends Component<IProps, IState> {
             ? messages.wakeUpService
             : messages.hibernateService,
         ),
-        // eslint-disable-next-line no-confusing-arrow
+
         click: () =>
           service.isHibernating ? wakeUpService() : hibernateService(),
         enabled: service.isEnabled && service.canHibernate,
@@ -311,7 +311,7 @@ class TabItem extends Component<IProps, IState> {
       {
         label: intl.formatMessage(messages.deleteService),
         click: () => {
-          // @ts-ignore
+          // @ts-expect-error Fix me
           const selection = dialog.showMessageBoxSync(app.mainWindow, {
             type: 'question',
             message: intl.formatMessage(messages.deleteService),
@@ -417,6 +417,6 @@ class TabItem extends Component<IProps, IState> {
 }
 
 export default injectIntl(
-  // @ts-ignore
+  // @ts-expect-error Fix me
   SortableElement(injectSheet(styles, { injectTheme: true })(TabItem)),
 );
diff --git a/src/components/services/tabs/Tabbar.tsx b/src/components/services/tabs/Tabbar.tsx
index f09877b2f..d19a4b8de 100644
--- a/src/components/services/tabs/Tabbar.tsx
+++ b/src/components/services/tabs/Tabbar.tsx
@@ -99,7 +99,7 @@ class TabBar extends Component<IProps> {
     return (
       <div>
         <TabBarSortableList
-          // @ts-ignore
+          // @ts-expect-error Fix me
           services={services}
           setActive={setActive}
           onSortEnd={this.onSortEnd}
-- 
cgit v1.2.3-70-g09d2