From 42ed24d5fd3586537f94f52bfc0b287a5fdbe6ea Mon Sep 17 00:00:00 2001 From: Stefan Malzner Date: Sat, 18 Nov 2017 21:46:45 +0100 Subject: fix(Menu): Add fallback to service menu when service name is empty Closes #250 --- src/lib/Menu.js | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/lib/Menu.js b/src/lib/Menu.js index 8f0a92c3d..753d5970e 100644 --- a/src/lib/Menu.js +++ b/src/lib/Menu.js @@ -277,7 +277,7 @@ export default class FranzMenu { if (this.stores.user.isLoggedIn) { return services.map((service, i) => ({ - label: service.name, + label: this._getServiceName(service), accelerator: i <= 9 ? `CmdOrCtrl+${i + 1}` : null, type: 'radio', checked: service.isActive, @@ -289,4 +289,20 @@ export default class FranzMenu { return []; } + + _getServiceName(service) { + if (service.name) { + return service.name; + } + + let name = service.recipe.name; + + if (service.team) { + name = `${name} (${service.team})`; + } else if (service.customUrl) { + name = `${name} (${service.customUrl})`; + } + + return name; + } } -- cgit v1.2.3-54-g00ecf From 97eb47cf1a04f3499b7334c9e952c0b6b2b29a53 Mon Sep 17 00:00:00 2001 From: Stefan Malzner Date: Sat, 18 Nov 2017 22:14:00 +0100 Subject: Remove unused menu config --- src/lib/Menu.js | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/src/lib/Menu.js b/src/lib/Menu.js index 753d5970e..6624ab75e 100644 --- a/src/lib/Menu.js +++ b/src/lib/Menu.js @@ -214,30 +214,6 @@ export default class FranzMenu { ], }, ); - // Window menu. - tpl[3].submenu = [ - { - // label: 'Close', - accelerator: 'CmdOrCtrl+W', - role: 'close', - }, - { - // label: 'Minimize', - accelerator: 'CmdOrCtrl+M', - role: 'minimize', - }, - { - // label: 'Zoom', - role: 'zoom', - }, - { - type: 'separator', - }, - { - // label: 'Bring All to Front', - role: 'front', - }, - ]; } else { tpl[4].submenu.unshift({ role: 'about', -- cgit v1.2.3-54-g00ecf