From 7e1cbf7a027b3dc4a02001b611452ddbf8879ca7 Mon Sep 17 00:00:00 2001 From: Vijay Aravamudhan Date: Mon, 11 Oct 2021 11:25:48 +0530 Subject: upgrade 'node-gyp' to '8.2.0' (#2053) --- .github/workflows/dependency-updates.yml | 2 +- .github/workflows/ferdi-builds.yml | 6 +++--- CONTRIBUTING.md | 6 +++--- Dockerfile | 2 +- package.json | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/dependency-updates.yml b/.github/workflows/dependency-updates.yml index eafa6645e..4931989f1 100644 --- a/.github/workflows/dependency-updates.yml +++ b/.github/workflows/dependency-updates.yml @@ -59,7 +59,7 @@ jobs: - name: Uninstall locally and reinstall global npm modules run: | npm uninstall node-gyp - npm ls -g node-gyp@8.1.0 || npm i -g node-gyp@8.1.0 + npm ls -g node-gyp@8.2.0 || npm i -g node-gyp@8.2.0 npm ls -g lerna@4.0.0 || npm i -g lerna@4.0.0 - name: Install node dependencies recursively run: npx lerna bootstrap diff --git a/.github/workflows/ferdi-builds.yml b/.github/workflows/ferdi-builds.yml index 062243659..0f15a3ec3 100644 --- a/.github/workflows/ferdi-builds.yml +++ b/.github/workflows/ferdi-builds.yml @@ -156,7 +156,7 @@ jobs: - name: Uninstall locally and reinstall global npm modules run: | npm uninstall node-gyp - npm ls -g node-gyp@8.1.0 || npm i -g node-gyp@8.1.0 + npm ls -g node-gyp@8.2.0 || npm i -g node-gyp@8.2.0 npm ls -g lerna@4.0.0 || npm i -g lerna@4.0.0 - name: Install node dependencies recursively run: npx lerna bootstrap @@ -260,7 +260,7 @@ jobs: - name: Uninstall locally and reinstall global npm modules run: | npm uninstall node-gyp - npm ls -g node-gyp@8.1.0 || npm i -g node-gyp@8.1.0 + npm ls -g node-gyp@8.2.0 || npm i -g node-gyp@8.2.0 npm ls -g lerna@4.0.0 || npm i -g lerna@4.0.0 - name: Install node dependencies recursively run: npx lerna bootstrap @@ -385,7 +385,7 @@ jobs: - name: Uninstall locally and reinstall global npm modules run: | npm uninstall node-gyp - npm ls -g node-gyp@8.1.0 || npm i -g node-gyp@8.1.0 + npm ls -g node-gyp@8.2.0 || npm i -g node-gyp@8.2.0 npm ls -g lerna@4.0.0 || npm i -g lerna@4.0.0 shell: bash - name: Install node dependencies recursively diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 76ad5266b..49ec44b3f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -13,7 +13,7 @@ - [How Can I Contribute?](#how-can-i-contribute) - [Setting up your Development machine](#setting-up-your-development-machine) - [Install System-level dependencies](#install-system-level-dependencies) - - [Node.js, npm, node-gyp](#nodejs-npm-node-gyp) + - [Node.js, npm, pnpm](#nodejs-npm-pnpm) - [Git](#git) - [Debian/Ubuntu](#debianubuntu) - [Fedora](#fedora) @@ -56,7 +56,7 @@ As a basic rule, before filing issues, feature requests or anything else. Take a ### Install System-level dependencies -#### Node.js, npm, node-gyp +#### Node.js, npm, pnpm Please make sure you are conforming to the `engines` requirements used by the developers/contributors as specified in the [package.json file](./package.json#engines). @@ -104,7 +104,7 @@ npm i -g windows-build-tools --vs2015 We need `node-gyp` to be able to compile any native dependencies ```bash -npm ls -g node-gyp@8.1.0 || npm i -g node-gyp@8.1.0 +npm ls -g node-gyp@8.2.0 || npm i -g node-gyp@8.2.0 ``` #### Lerna diff --git a/Dockerfile b/Dockerfile index cb3053708..bccfdd6fc 100644 --- a/Dockerfile +++ b/Dockerfile @@ -17,7 +17,7 @@ RUN apt-get update -y \ WORKDIR /usr/src/ferdi RUN npm i -g pnpm@6.16.0 \ - && npm ls -g node-gyp@8.1.0 || npm i -g node-gyp@8.1.0 \ + && npm ls -g node-gyp@8.2.0 || npm i -g node-gyp@8.2.0 \ && npm ls -g lerna@4.0.0 || npm i -g lerna@4.0.0 COPY package*.json . diff --git a/package.json b/package.json index 9a1ecf549..cc5abc21d 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,7 @@ "engines": { "node": "^14.17", "npm": "^6.14", - "node-gyp": "^8.1" + "node-gyp": "^8.2" }, "engine-strict": true, "scripts": { -- cgit v1.2.3-70-g09d2