From 6df93308d7a93cccb281f3e979668df23007ab5d Mon Sep 17 00:00:00 2001 From: muhamedsalih-tw <104364298+muhamedsalih-tw@users.noreply.github.com> Date: Thu, 1 Dec 2022 00:33:39 +0530 Subject: chore: [#42] use noop consistently throughout (#808) --- src/components/auth/Invite.tsx | 2 +- src/components/auth/Locked.tsx | 2 +- src/components/auth/Login.tsx | 2 +- src/components/auth/Password.tsx | 2 +- src/components/auth/Signup.tsx | 2 +- src/components/settings/services/EditServiceForm.tsx | 3 ++- src/components/settings/settings/EditSettingsForm.tsx | 3 ++- src/components/settings/user/EditUserForm.tsx | 2 +- src/components/ui/input/index.tsx | 2 +- src/components/ui/select/index.tsx | 2 +- src/components/ui/textarea/index.tsx | 7 ++++--- src/features/workspaces/components/EditWorkspaceForm.tsx | 3 ++- src/webview/recipe.ts | 4 ++-- 13 files changed, 20 insertions(+), 16 deletions(-) diff --git a/src/components/auth/Invite.tsx b/src/components/auth/Invite.tsx index 7723ea1ac..4ab5157a8 100644 --- a/src/components/auth/Invite.tsx +++ b/src/components/auth/Invite.tsx @@ -117,7 +117,7 @@ class Invite extends Component { this.setState({ showSuccessInfo: true }); }, - onError: () => {}, + onError: noop, }); } diff --git a/src/components/auth/Locked.tsx b/src/components/auth/Locked.tsx index 8b4e26878..00ff5a4c5 100644 --- a/src/components/auth/Locked.tsx +++ b/src/components/auth/Locked.tsx @@ -72,7 +72,7 @@ class Locked extends Component { onSuccess: form => { this.props.onSubmit(form.values()); }, - onError: () => {}, + onError: noop, }); } diff --git a/src/components/auth/Login.tsx b/src/components/auth/Login.tsx index 185a6ad48..0a95b0565 100644 --- a/src/components/auth/Login.tsx +++ b/src/components/auth/Login.tsx @@ -103,7 +103,7 @@ class Login extends Component { onSuccess: form => { this.props.onSubmit(form.values()); }, - onError: () => {}, + onError: noop, }); } diff --git a/src/components/auth/Password.tsx b/src/components/auth/Password.tsx index 53fdbf842..03adc3859 100644 --- a/src/components/auth/Password.tsx +++ b/src/components/auth/Password.tsx @@ -71,7 +71,7 @@ class Password extends Component { onSuccess: form => { this.props.onSubmit(form.values()); }, - onError: () => {}, + onError: noop, }); } diff --git a/src/components/auth/Signup.tsx b/src/components/auth/Signup.tsx index af14430aa..fb2a2360e 100644 --- a/src/components/auth/Signup.tsx +++ b/src/components/auth/Signup.tsx @@ -114,7 +114,7 @@ class Signup extends Component { onSuccess: form => { this.props.onSubmit(form.values()); }, - onError: () => {}, + onError: noop, }); } diff --git a/src/components/settings/services/EditServiceForm.tsx b/src/components/settings/services/EditServiceForm.tsx index 7104b1344..2b87dff1e 100644 --- a/src/components/settings/services/EditServiceForm.tsx +++ b/src/components/settings/services/EditServiceForm.tsx @@ -4,6 +4,7 @@ import { Link } from 'react-router-dom'; import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl'; import normalizeUrl from 'normalize-url'; import { mdiInformation } from '@mdi/js'; +import { noop } from 'lodash'; import Form from '../../../lib/Form'; import Tabs from '../../ui/Tabs/Tabs'; import TabItem from '../../ui/Tabs/TabItem'; @@ -213,7 +214,7 @@ class EditServiceForm extends Component { this.setState({ isValidatingCustomUrl: false }); }, - onError: () => {}, + onError: noop, }); } diff --git a/src/components/settings/settings/EditSettingsForm.tsx b/src/components/settings/settings/EditSettingsForm.tsx index c8e7e2c45..49798dd92 100644 --- a/src/components/settings/settings/EditSettingsForm.tsx +++ b/src/components/settings/settings/EditSettingsForm.tsx @@ -4,6 +4,7 @@ import { observer } from 'mobx-react'; import prettyBytes from 'pretty-bytes'; import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl'; import { mdiGithub, mdiOpenInNew, mdiPowerPlug } from '@mdi/js'; +import { noop } from 'lodash'; import Form from '../../../lib/Form'; import Button from '../../ui/button'; import Toggle from '../../ui/toggle'; @@ -343,7 +344,7 @@ class EditSettingsForm extends Component { } this.props.onSubmit(values); }, - onError: () => {}, + onError: noop, }); } diff --git a/src/components/settings/user/EditUserForm.tsx b/src/components/settings/user/EditUserForm.tsx index 3b604a79f..5a2a5a83e 100644 --- a/src/components/settings/user/EditUserForm.tsx +++ b/src/components/settings/user/EditUserForm.tsx @@ -53,7 +53,7 @@ class EditUserForm extends Component { const values = form.values(); this.props.onSubmit(values); }, - onError: () => {}, + onError: noop, }); } diff --git a/src/components/ui/input/index.tsx b/src/components/ui/input/index.tsx index a6d401195..fe8f35607 100644 --- a/src/components/ui/input/index.tsx +++ b/src/components/ui/input/index.tsx @@ -42,7 +42,7 @@ interface IProps showPasswordToggle?: boolean; data?: IData; inputClassName?: string; - onEnterKey?: () => {}; + onEnterKey?: () => void; } interface IState { diff --git a/src/components/ui/select/index.tsx b/src/components/ui/select/index.tsx index b22c15320..31aa8a15f 100644 --- a/src/components/ui/select/index.tsx +++ b/src/components/ui/select/index.tsx @@ -386,7 +386,7 @@ class SelectComponent extends Component { this.setState((state: IState) => ({ open: !state.open, })) - : () => {} + : noop } > {selection} diff --git a/src/components/ui/textarea/index.tsx b/src/components/ui/textarea/index.tsx index d4ea424be..89e85ac11 100644 --- a/src/components/ui/textarea/index.tsx +++ b/src/components/ui/textarea/index.tsx @@ -2,6 +2,7 @@ import classnames from 'classnames'; import { Component, createRef, TextareaHTMLAttributes } from 'react'; import injectSheet, { WithStylesProps } from 'react-jss'; +import { noop } from 'lodash'; import { IFormField } from '../typings/generic'; import Error from '../error'; @@ -24,9 +25,9 @@ interface IProps class TextareaComponent extends Component { static defaultProps = { - onChange: () => {}, - onBlur: () => {}, - onFocus: () => {}, + onChange: noop, + onBlur: noop, + onFocus: noop, showLabel: true, disabled: false, rows: 5, diff --git a/src/features/workspaces/components/EditWorkspaceForm.tsx b/src/features/workspaces/components/EditWorkspaceForm.tsx index a860ac2e8..d902d29be 100644 --- a/src/features/workspaces/components/EditWorkspaceForm.tsx +++ b/src/features/workspaces/components/EditWorkspaceForm.tsx @@ -3,6 +3,7 @@ import { observer } from 'mobx-react'; import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl'; import { Link } from 'react-router-dom'; import withStyles, { WithStylesProps } from 'react-jss'; +import { noop } from 'lodash'; import Infobox from '../../../components/ui/infobox/index'; import Input from '../../../components/ui/input'; import Button from '../../../components/ui/button'; @@ -127,7 +128,7 @@ class EditWorkspaceForm extends Component { const values = f.values(); onSave(values); }, - onError: async () => {}, + onError: noop, }); } diff --git a/src/webview/recipe.ts b/src/webview/recipe.ts index b3a4a6b56..dc3f39401 100644 --- a/src/webview/recipe.ts +++ b/src/webview/recipe.ts @@ -1,11 +1,11 @@ /* eslint-disable global-require */ /* eslint-disable import/no-dynamic-require */ /* eslint-disable import/first */ +import { noop, debounce } from 'lodash'; import { contextBridge, ipcRenderer } from 'electron'; import { join } from 'path'; import { autorun, computed, makeObservable, observable } from 'mobx'; import { pathExistsSync, readFileSync } from 'fs-extra'; -import { debounce } from 'lodash'; import { disable as disableDarkMode, enable as enableDarkMode, @@ -53,7 +53,7 @@ import Service from '../models/Service'; // As the message API is not actually needed, we'll add this shim sendMessage // function in order for darkreader to continue working // @ts-ignore -window.chrome.runtime.sendMessage = () => {}; +window.chrome.runtime.sendMessage = noop; const debug = require('../preload-safe-debug')('Ferdium:Plugin'); -- cgit v1.2.3-54-g00ecf