From 2993efc83e7f557a9c36e7915a54c62c5f90296e Mon Sep 17 00:00:00 2001 From: Vijay Raghavan Aravamudhan Date: Mon, 26 Jul 2021 04:04:27 +0000 Subject: Use node-gyp@8.1 for all CI builds (and brings windows at par with macos and linux) (#1690) Upgraded node-gyp to '8.1.0' (since this was a pre-requisite for it to work on windows os) --- .github/workflows/dependency-updates.yml | 2 +- .github/workflows/ferdi-builds.yml | 9 +++++++-- CONTRIBUTING.md | 2 +- Dockerfile | 2 +- package.json | 2 +- 5 files changed, 11 insertions(+), 6 deletions(-) diff --git a/.github/workflows/dependency-updates.yml b/.github/workflows/dependency-updates.yml index cb40dc27c..24f02bdc5 100644 --- a/.github/workflows/dependency-updates.yml +++ b/.github/workflows/dependency-updates.yml @@ -48,7 +48,7 @@ jobs: - name: Uninstall locally and reinstall node-gyp globally run: | npm uninstall node-gyp - npm i -g node-gyp@8.0.0 && npm config set node_gyp "$(which node-gyp)" + npm i -g node-gyp@8.1.0 && npm config set node_gyp "$(which node-gyp)" - name: Install node dependencies recursively run: npx lerna bootstrap - name: Update submodules diff --git a/.github/workflows/ferdi-builds.yml b/.github/workflows/ferdi-builds.yml index 6c45e65b5..3e53d4e71 100644 --- a/.github/workflows/ferdi-builds.yml +++ b/.github/workflows/ferdi-builds.yml @@ -129,7 +129,7 @@ jobs: - name: Uninstall locally and reinstall node-gyp globally run: | npm uninstall node-gyp - npm i -g node-gyp@8.0.0 && npm config set node_gyp "$(which node-gyp)" + npm i -g node-gyp@8.1.0 - name: Fix corrupted node cache run: npm cache clean --force - name: Install node dependencies recursively @@ -222,7 +222,7 @@ jobs: - name: Uninstall locally and reinstall node-gyp globally run: | npm uninstall node-gyp - npm i -g node-gyp@8.0.0 && npm config set node_gyp "$(which node-gyp)" + npm i -g node-gyp@8.1.0 - name: Fix corrupted node cache run: npm cache clean --force - name: Install node dependencies recursively @@ -308,6 +308,11 @@ jobs: uses: actions/setup-node@v2 with: node-version: 14.17.3 + - name: Uninstall locally and reinstall node-gyp globally + run: | + npm uninstall node-gyp + npm i -g node-gyp@8.1.0 + shell: bash - name: Fix corrupted node cache run: npm cache clean --force shell: bash diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0b643ea10..ec487283c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -62,7 +62,7 @@ v14.17.3 npm -v 6.14.12 node-gyp -v -v8.0.0 +v8.1.0 ``` #### Git diff --git a/Dockerfile b/Dockerfile index bb0381d31..c78a36596 100644 --- a/Dockerfile +++ b/Dockerfile @@ -21,7 +21,7 @@ WORKDIR /usr/src/ferdi COPY package*.json ./ COPY lerna.json ./ -RUN npm i -g node-gyp@8.0.0 \ +RUN npm i -g node-gyp@8.1.0 \ && npm config set node_gyp "$(which node-gyp)" COPY . . diff --git a/package.json b/package.json index 58108204c..3dfb750c7 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,7 @@ "engines": { "node": "^14.17", "npm": "^6.14", - "node-gyp": "^8.0" + "node-gyp": "^8.1" }, "engine-strict": true, "scripts": { -- cgit v1.2.3-54-g00ecf