refactor: project maintenance (#1682)

- remove redundant `@adonisjs/auth`, `@adonisjs/session` and `@emotion/react` dependencies
- remove `.vscode` folder
- clean up some TS and ESLint issues
- migrate from deprecated "husky install" to "husky"

4 files changed, 18 insertions, 21 deletions

diff --git a/src/api/server/ServerApi.ts b/src/api/server/ServerApi.ts
index 69994114e..ab6866b13 100644
--- a/src/api/server/ServerApi.ts
+++ b/src/api/server/ServerApi.ts
@@ -379,8 +379,7 @@ export default class ServerApi {
       .filter(recipe => recipe.id);
 
     // @ts-expect-error Type 'boolean' is not assignable to type 'ConcatArray<IRecipe>'.
-    // eslint-disable-next-line unicorn/prefer-spread
-    this.recipes = this.recipes.concat(this._getDevRecipes());
+    this.recipes = [...this.recipes, ...this._getDevRecipes()];
 
     debug('StubServerApi::getInstalledRecipes resolves', this.recipes);
     return this.recipes;
@@ -582,7 +581,7 @@ export default class ServerApi {
           file !== 'temp',
       );
 
-      const recipes = paths
+      const recipes: IRecipe[] = paths
         .map(id => {
           try {
             // eslint-disable-next-line import/no-dynamic-require
diff --git a/src/models/Recipe.ts b/src/models/Recipe.ts
index e8f11df5f..11eb1884f 100644
--- a/src/models/Recipe.ts
+++ b/src/models/Recipe.ts
@@ -50,14 +50,14 @@ export interface IRecipe {
   partition: string;
   local: boolean;
 
-  // eslint-disable-next-line @typescript-eslint/ban-types
-  readonly overrideUserAgent?: null | Function;
-  // eslint-disable-next-line @typescript-eslint/ban-types
-  readonly buildUrl?: null | Function;
-  // eslint-disable-next-line @typescript-eslint/ban-types
-  readonly modifyRequestHeaders?: null | Function;
-  // eslint-disable-next-line @typescript-eslint/ban-types
-  readonly knownCertificateHosts?: null | Function;
+  readonly overrideUserAgent?: () => string;
+
+  readonly buildUrl?: (url: string) => string;
+
+  readonly modifyRequestHeaders?: () => void;
+
+  readonly knownCertificateHosts?: () => void;
+
   readonly events?: null | ((key: string) => string);
 
   // TODO: [TS DEBT] Need to check if below properties are needed and where is inherited / implemented from
diff --git a/src/stores/SettingsStore.ts b/src/stores/SettingsStore.ts
index 72d6331cb..29f173f91 100644
--- a/src/stores/SettingsStore.ts
+++ b/src/stores/SettingsStore.ts
@@ -183,8 +183,10 @@ export default class SettingsStore extends TypedStore {
     }
   }
 
-  // eslint-disable-next-line @typescript-eslint/ban-types
-  _ensureMigrationAndMarkDone(migrationName: string, callback: Function): void {
+  _ensureMigrationAndMarkDone(
+    migrationName: string,
+    callback: () => void,
+  ): void {
     if (!this.all.migration[migrationName]) {
       callback();
 
diff --git a/src/webview/contextMenuBuilder.ts b/src/webview/contextMenuBuilder.ts
index dd39560da..f81b051ee 100644
--- a/src/webview/contextMenuBuilder.ts
+++ b/src/webview/contextMenuBuilder.ts
@@ -288,11 +288,9 @@ export class ContextMenuBuilder {
     this.addPaste(menu, menuInfo);
     this.addPastePlain(menu, menuInfo);
     this.addInspectElement(menu, menuInfo);
-    // @ts-expect-error Expected 1 arguments, but got 2.
-    this.processMenu(menu, menuInfo);
+    this.processMenu(menu);
 
-    // @ts-expect-error Expected 2 arguments, but got 1.
-    this.copyPageUrl(menu);
+    this.copyPageUrl(menu, menuInfo);
     this.goToHomePage(menu, menuInfo);
     this.openInBrowser(menu, menuInfo);
 
@@ -349,14 +347,12 @@ export class ContextMenuBuilder {
     }
 
     this.addInspectElement(menu, menuInfo);
-    // @ts-expect-error Expected 1 arguments, but got 2.
-    this.processMenu(menu, menuInfo);
+    this.processMenu(menu);
 
     this.addSeparator(menu);
     this.goBack(menu);
     this.goForward(menu);
-    // @ts-expect-error Expected 2 arguments, but got 1.
-    this.copyPageUrl(menu);
+    this.copyPageUrl(menu, menuInfo);
     this.goToHomePage(menu, menuInfo);
     this.openInBrowser(menu, menuInfo);