Do not allow http urls that end in '/' (fixes #102) (#103)

3 files changed, 5 insertions, 2 deletions

diff --git a/src/helpers/url-helpers.ts b/src/helpers/url-helpers.ts
index ddbf4b4f7..ef2805595 100644
--- a/src/helpers/url-helpers.ts
+++ b/src/helpers/url-helpers.ts
@@ -15,6 +15,9 @@ export function isValidExternalURL(url: string | URL) {
   } catch {
     return false;
   }
+  if (url.toString().endsWith('/')) {
+    return false;
+  }
 
   const isAllowed = ALLOWED_PROTOCOLS.includes(parsedUrl.protocol);
 
diff --git a/src/helpers/validation-helpers.ts b/src/helpers/validation-helpers.ts
index 4e0af8b08..c3c0f79bf 100644
--- a/src/helpers/validation-helpers.ts
+++ b/src/helpers/validation-helpers.ts
@@ -13,7 +13,7 @@ const messages = defineMessages({
   },
   url: {
     id: 'validation.url',
-    defaultMessage: '{field} is not a valid URL',
+    defaultMessage: "{field} is not a valid URL (cannot end in '/')",
   },
   minLength: {
     id: 'validation.minLength',
diff --git a/src/i18n/locales/en-US.json b/src/i18n/locales/en-US.json
index 095c12762..22061fc9c 100644
--- a/src/i18n/locales/en-US.json
+++ b/src/i18n/locales/en-US.json
@@ -432,7 +432,7 @@
   "validation.minLength": "{field} should be at least {length} characters long",
   "validation.oneRequired": "At least one is required",
   "validation.required": "{field} is required",
-  "validation.url": "{field} is not a valid URL",
+  "validation.url": "{field} is not a valid URL (cannot end in '/')",
   "webControls.back": "Back",
   "webControls.forward": "Forward",
   "webControls.goHome": "Home",