Adding DuckDuckGo as an alternative search engine (#1414)

* Adding DuckDuckGo as an alternative search engine.

* Fixing review comments.

* Fixing review comments.

3 files changed, 9 insertions, 6 deletions

diff --git a/src/webview/contextMenu.js b/src/webview/contextMenu.js
index 679bf5aaa..5858e89ef 100644
--- a/src/webview/contextMenu.js
+++ b/src/webview/contextMenu.js
@@ -3,7 +3,7 @@ import ContextMenuBuilder from './contextMenuBuilder';
 
 const webContents = remote.getCurrentWebContents();
 
-export default async function setupContextMenu(isSpellcheckEnabled, getDefaultSpellcheckerLanguage, getSpellcheckerLanguage) {
+export default async function setupContextMenu(isSpellcheckEnabled, getDefaultSpellcheckerLanguage, getSpellcheckerLanguage, getSearchEngine) {
   const contextMenuBuilder = new ContextMenuBuilder(
     webContents,
   );
@@ -11,7 +11,7 @@ export default async function setupContextMenu(isSpellcheckEnabled, getDefaultSp
   webContents.on('context-menu', (e, props) => {
     // TODO?: e.preventDefault();
     contextMenuBuilder.showPopupMenu(
-      props,
+      { ...props, searchEngine: getSearchEngine() },
       isSpellcheckEnabled(),
       getDefaultSpellcheckerLanguage(),
       getSpellcheckerLanguage(),
diff --git a/src/webview/contextMenuBuilder.js b/src/webview/contextMenuBuilder.js
index b5095915c..49c4550a9 100644
--- a/src/webview/contextMenuBuilder.js
+++ b/src/webview/contextMenuBuilder.js
@@ -8,6 +8,8 @@
  */
 import { isMac } from '../environment';
 
+import { SEARCH_ENGINE_NAMES, SEARCH_ENGINE_URLS } from '../config';
+
 const {
   clipboard, nativeImage, remote, shell,
 } = require('electron');
@@ -27,7 +29,7 @@ const contextMenuStringTable = {
   cut: () => 'Cut',
   copy: () => 'Copy',
   paste: () => 'Paste',
-  searchGoogle: () => 'Search with Google',
+  searchWith: ({ searchEngine }) => `Search with ${searchEngine}`,
   openLinkUrl: () => 'Open Link',
   openLinkInFerdiUrl: () => 'Open Link in Ferdi',
   openInBrowser: () => 'Open in Browser',
@@ -286,10 +288,9 @@ module.exports = class ContextMenuBuilder {
     }
 
     const search = new MenuItem({
-      label: this.stringTable.searchGoogle(),
+      label: this.stringTable.searchWith({ searchEngine: SEARCH_ENGINE_NAMES[menuInfo.searchEngine] }),
       click: () => {
-        const url = `https://www.google.com/search?q=${encodeURIComponent(menuInfo.selectionText)}`;
-
+        const url = SEARCH_ENGINE_URLS[menuInfo.searchEngine]({ searchTerm: encodeURIComponent(menuInfo.selectionText) });
         shell.openExternal(url);
       },
     });
diff --git a/src/webview/recipe.js b/src/webview/recipe.js
index 2319e8e2a..2701603cb 100644
--- a/src/webview/recipe.js
+++ b/src/webview/recipe.js
@@ -152,6 +152,7 @@ class RecipeController {
       () => this.settings.app.enableSpellchecking,
       () => this.settings.app.spellcheckerLanguage,
       () => this.spellcheckerLanguage,
+      () => this.settings.app.searchEngine,
     );
 
     autorun(() => this.update());
@@ -230,6 +231,7 @@ class RecipeController {
     debug('System spellcheckerLanguage', this.settings.app.spellcheckerLanguage);
     debug('Service spellcheckerLanguage', this.settings.service.spellcheckerLanguage);
     debug('darkReaderSettigs', this.settings.service.darkReaderSettings);
+    debug('searchEngine', this.settings.app.searchEngine);
 
     if (this.userscript && this.userscript.internal_setSettings) {
       this.userscript.internal_setSettings(this.settings);