diff options
author | MCMXC <16797721+mcmxcdev@users.noreply.github.com> | 2023-07-29 21:12:16 -0600 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-07-30 08:42:16 +0530 |
commit | 32f76b74a69ad4d60a014bf075c39517888436bc (patch) | |
tree | 753378cc30f52d1e0e51be64b5a83d39f08f39c8 /src/webview/contextMenuBuilder.ts | |
parent | 6.4.1-nightly.15 [skip ci] (diff) | |
download | ferdium-app-32f76b74a69ad4d60a014bf075c39517888436bc.tar.gz ferdium-app-32f76b74a69ad4d60a014bf075c39517888436bc.tar.zst ferdium-app-32f76b74a69ad4d60a014bf075c39517888436bc.zip |
refactor: various improvements (#1296)
* refactor: various improvements
- enable no-use-before-define eslint rule
- shuffle code to conform to no-use-before-define eslint rule
- remove btoa dependency which is deprecated and replace with Buffer.from(string).toString('base64')
- convert some any types into useful ones
- add type annotations where possible
- remove unused @types/expect.js
- install @types/semver and ts-node which were missing
- repair and rewrite add-crowdin-contributors script
- remove export keyword from variables which are never consumed in another file
- remove unity indicator hack where linked issue was closed
- remove module declaration for kebab-case which is unused
- add missing state interface for certain components
- remove default exports for files which already have a named export
- export IRecipePreview so it can be used throughout codebase
- remove unused removeCacheForCallWith method from CachedRequest.ts
- cleanup unused colors and styles inside legacy theme
* - improve ColorPickerInput
- fix invalid DOM nesting with div inside p in EditSettingsForm
- fix progressbarAccentColor color picker not updating input when using slider
- install missing @types/react-color dependency
Diffstat (limited to 'src/webview/contextMenuBuilder.ts')
-rw-r--r-- | src/webview/contextMenuBuilder.ts | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/webview/contextMenuBuilder.ts b/src/webview/contextMenuBuilder.ts index 0d8b659f0..93dfbebb6 100644 --- a/src/webview/contextMenuBuilder.ts +++ b/src/webview/contextMenuBuilder.ts | |||
@@ -675,7 +675,7 @@ export class ContextMenuBuilder { | |||
675 | const clickHandler = menuInfo.srcURL.startsWith('blob:') | 675 | const clickHandler = menuInfo.srcURL.startsWith('blob:') |
676 | ? () => { | 676 | ? () => { |
677 | const urlWithoutBlob = menuInfo.srcURL.slice(5); | 677 | const urlWithoutBlob = menuInfo.srcURL.slice(5); |
678 | this.convertImageToBase64(menuInfo.srcURL, (dataURL: any) => { | 678 | this.convertImageToBase64(menuInfo.srcURL, (dataURL: string) => { |
679 | const url = new window.URL(urlWithoutBlob); | 679 | const url = new window.URL(urlWithoutBlob); |
680 | const fileName = url.pathname.slice(1); | 680 | const fileName = url.pathname.slice(1); |
681 | ipcRenderer.send('download-file', { | 681 | ipcRenderer.send('download-file', { |
@@ -834,9 +834,8 @@ export class ContextMenuBuilder { | |||
834 | convertImageToBase64( | 834 | convertImageToBase64( |
835 | url: string, | 835 | url: string, |
836 | callback: { | 836 | callback: { |
837 | (dataURL: any): void; | 837 | (dataURL: string): void; |
838 | (dataURL: any): void; | 838 | (dataURL: string): void; |
839 | // eslint-disable-next-line @typescript-eslint/unified-signatures | ||
840 | (arg0: string): void; | 839 | (arg0: string): void; |
841 | }, | 840 | }, |
842 | outputFormat: string = 'image/png', | 841 | outputFormat: string = 'image/png', |